fix: complete repeated variadic args

[Jai-JAP]

Summary

This fixes completions for repeated variadic positional arguments after the first value has already been entered.

complete-word used the number of parsed positional entries to decide which positional argument to complete next.
That works for normal positionals, but not for variadic args as all values for the repeated args are stored under single positional entry. After typing one value, the arg was incorrectly marked done and fell back to file completions.

The fix checks the parsed value for each positional arg instead. If the arg is variadic and has not reached var_max, it keeps using the same arg's completer. If var_max is reached, it moves on and normal fallback behavior applies.

Also added regression tests for the same.

Related

• variable arguments don't get completed after the first one #458
• variable arguments don't get completed after the first one mise#4774
• [Bug]: Mise package completions only work for the first argument mise#11393

Validation

• mise run test -- complete_word_variadic
• mise run test

Summary by CodeRabbit

• Bug Fixes

  • Improved CLI completion for variadic arguments.
  • Bounded variadic arguments now stop completing after reaching their maximum allowed items.
  • Completion correctly advances to subsequent arguments or file completion when appropriate.

• Tests

  • Added regression coverage for repeated and bounded variadic argument completion.

• Documentation

  • Added an example configuration demonstrating variadic and bounded argument completion.

[coderabbitai]

📝 Walkthrough

Walkthrough

Completion now selects the next unfinished positional argument using parsed variadic state, respects var_max, and adds example-backed regression tests for reusable and bounded variadic completions.

Changes

Variadic completion

Layer / File(s)	Summary
Select the next completable argument cli/src/cli/complete_word.rs	Completion scans parsed arguments and continues a variadic argument until its configured maximum before moving to later arguments.
Define and validate variadic behavior examples/variadic-completion.usage.kdl, cli/tests/complete_word.rs	Adds reusable and bounded variadic commands with foo/bar completions and tests fallback behavior after the bound is reached.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Shell
  participant complete_word
  participant ParseOutput
  participant SpecArg
  Shell->>complete_word: request completion
  complete_word->>ParseOutput: inspect parsed values
  complete_word->>SpecArg: select next completable argument
  SpecArg-->>complete_word: return missing or available variadic argument
  complete_word-->>Shell: return candidates or file completion

Loading

Suggested reviewers: jdx, jambalaya56562

Poem

A rabbit hops through args in a row,
Finding the next place strings may go.
“Foo!” and “bar!” the tokens cheer,
Until the bound says, “No more here.”
Then files appear with a gentle glow.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: fixing completion for repeated variadic positional arguments.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

This PR corrects dynamic completion selection for repeated variadic positional arguments.

• Selects the next positional completer from parsed argument values rather than the number of parsed entries.
• Keeps a variadic argument active until its configured var_max is reached.
• Adds regression coverage and an example specification for bounded and unbounded variadic completion.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
cli/src/cli/complete_word.rs	Updates positional completion selection to reuse variadic completers until their maximum value count is reached.
cli/tests/complete_word.rs	Adds end-to-end regression tests for repeated unbounded and bounded variadic completions.
examples/variadic-completion.usage.kdl	Adds bounded and unbounded variadic command fixtures with dynamic item completions.

_{Reviews (3): Last reviewed commit: "chore: run render" | Re-trigger Greptile}