Skip to content

fix(complete): skip unreadable files in fish shebang completion scan #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
Jul 6, 2026
Merged

fix(complete): skip unreadable files in fish shebang completion scan #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/src/complete/fish.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ function __usage_register_shebang_completions
test -d $dir; or continue
for file in $dir/*
test -f $file -a -x $file; or continue
# Skip files we can't read (e.g. setuid/execute-only binaries like
# macOS's sudo/visudo) — reading them below would make fish print
# a redirection warning on every shell startup.
test -r $file; or continue
# `string replace` works on every supported fish version; `path
# basename` requires fish 3.5+ which excludes Ubuntu 22.04 LTS.
set -l name (string replace -r '^.*/' '' -- $file)
Expand Down
4 changes: 4 additions & 0 deletions lib/src/complete/snapshots/usage__complete__fish__tests__complete_fish_init.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ function __usage_register_shebang_completions
test -d $dir; or continue
for file in $dir/*
test -f $file -a -x $file; or continue
# Skip files we can't read (e.g. setuid/execute-only binaries like
# macOS's sudo/visudo) — reading them below would make fish print
# a redirection warning on every shell startup.
test -r $file; or continue
# `string replace` works on every supported fish version; `path
# basename` requires fish 3.5+ which excludes Ubuntu 22.04 LTS.
set -l name (string replace -r '^.*/' '' -- $file)
Expand Down