fix(doctor): honor http timeout for version checks

[risu729]

Summary

• use the configured http_timeout for the mise doctor/version endpoint check instead of a hardcoded 3s timeout
• remove the dedicated version-check client so timeout hints point users at http_timeout / MISE_HTTP_TIMEOUT

History / Rationale

• edb8a32ea (feat(timeout): show duration, URL, and config hint on timeouts; increase fetch timeout default to 10s) introduced ClientKind::VersionCheck => ("version_check_timeout", "") alongside the hardcoded 3s HTTP_VERSION_CHECK client.
• That empty env var case was intentional: there was no real version_check_timeout setting/env var, so the timeout formatter avoided printing a misleading "change with ..." hint for version checks.
• This PR removes that special version-check client path. The version check now uses the regular HTTP client, so the former empty-env-var branch is no longer reachable and timeout messages correctly point to the real http_timeout / MISE_HTTP_TIMEOUT controls.

Discussion

• Addresses "mise doctor" fails version check with timeout #9934 (comment)

Tests

• git diff --check
• MISE_TRUSTED_CONFIG_PATHS=$PWD mise run build
• Removed the e2e test because this PR is small and there is no separate way to configure only the version-check timeout; forcing a slow timeout path in test coverage could be troublesome for low-speed internet users.

[greptile-apps]

Greptile Summary

This PR wires mise doctor's version-endpoint check through the standard HTTP client so it respects the user-configured http_timeout / MISE_HTTP_TIMEOUT instead of a hardcoded 3 s ceiling, and cleans up the dead code that was introduced alongside the old behaviour.

• Removes HTTP_VERSION_CHECK (hardcoded 3 s) and ClientKind::VersionCheck; the version check in src/cli/version.rs now calls HTTP directly.
• Simplifies the timeout-hint formatter in src/http.rs by eliminating the empty-env-var branch that only existed to suppress the "change with …" hint for VersionCheck — now every timeout message correctly points users at http_timeout / MISE_HTTP_TIMEOUT.

Confidence Score: 5/5

Safe to merge — the change is a clean removal of a now-redundant client and a corresponding simplification of dead conditional logic.

Both changed files are straightforward: the version check gains the user-configurable timeout it was missing, HTTP_VERSION_CHECK is fully removed with no remaining references, and the timeout-hint formatter loses only the branch that was guarding against an env-var that never existed as a real setting. The #[cfg(test)] stub for get_latest_version_call keeps tests unaffected by the HTTP client change.

No files require special attention.

Important Files Changed

Filename	Overview
src/http.rs	Removes HTTP_VERSION_CHECK static and ClientKind::VersionCheck variant; simplifies timeout-hint formatting by eliminating the empty-env-var branch that only existed for the removed variant.
src/cli/version.rs	Single-line change: get_latest_version_call now uses HTTP (user-configured timeout) instead of the removed HTTP_VERSION_CHECK (hardcoded 3 s).

_{Reviews (5): Last reviewed commit: "Merge branch 'main' into codex-20260519-..." | Re-trigger Greptile}

[gemini-code-assist]

Code Review

This pull request updates the version check HTTP client to honor the user-configured http_timeout setting instead of a hardcoded 3-second duration. It also removes the specialized VersionCheck client kind in favor of the standard Http kind and includes a new end-to-end test to verify that mise doctor correctly respects the MISE_HTTP_TIMEOUT environment variable. I have no feedback to provide as no review comments were submitted.

[Patterner]

this is by far one of the best reaction a bug report i've seen