Skip to content

fix(s3): support SSO-based AWS profiles by enabling aws-config sso feature#9875

Merged
jdx merged 1 commit into
jdx:mainfrom
Amir-Ahmad:fix-aws-sso
May 15, 2026
Merged

fix(s3): support SSO-based AWS profiles by enabling aws-config sso feature#9875
jdx merged 1 commit into
jdx:mainfrom
Amir-Ahmad:fix-aws-sso

Conversation

@Amir-Ahmad

@Amir-Ahmad Amir-Ahmad commented May 15, 2026

Copy link
Copy Markdown
Contributor

This fixes an issue where AWS authentication is broken if you use aws sso: https://aws.amazon.com/iam/identity-center/

Validation:

cargo test --all-features
mise run test:e2e
cargo deny check 

Have built the new binary and confirmed that AWS auth is now working for s3 downloads, fixes previous failure S3 error: DispatchFailure(DispatchFailure { source: ConnectorError { kind: Other(None), source: InvalidConfiguration(InvalidConfiguration { source: "ProfileFile provider could not be built: This behavior requires following cargo feature(s) enabled: sso. " }), connection: Unknown } })

This fixes an issue where you AWS authentication is broken if you use https://aws.amazon.com/iam/identity-center/
@greptile-apps

greptile-apps Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes AWS SSO (IAM Identity Center) authentication for S3 downloads by enabling the sso feature flag on the aws-config crate. Without it, the ProfileFile credential provider would fail at runtime with an InvalidConfiguration error whenever an SSO-based AWS profile was used.

  • Cargo.toml: Adds "sso" to the aws-config features list; no other dependency changes.
  • Cargo.lock: Introduces aws-sdk-sso v1.95.0 and aws-sdk-ssooidc v1.97.0 as new packages; all other newly-listed entries (hex, ring, zeroize) were already present in the lock file before this change.

Confidence Score: 5/5

Safe to merge — the change is a single feature flag addition that unlocks an existing, well-tested AWS SDK code path.

The fix is minimal and surgical: one line added to Cargo.toml, with a lock file update that only pulls in the two expected AWS SSO SDK crates. The pre-existing transitive dependencies (ring, hex, zeroize) were already in the tree, so binary size growth is limited to the SSO SDK itself. No logic changes, no API surface changes, no behaviour changes for non-SSO profiles.

No files require special attention.

Important Files Changed

Filename Overview
Cargo.toml Adds "sso" feature to the aws-config dependency — a targeted, correct fix to enable AWS IAM Identity Center (SSO) authentication support.
Cargo.lock Auto-generated lock file update adds aws-sdk-sso v1.95.0 and aws-sdk-ssooidc v1.97.0; all other newly-listed transitive deps (hex, ring, zeroize) were already present in the pre-PR lock file.

Reviews (1): Last reviewed commit: "Enable sso on aws-config features" | Re-trigger Greptile

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the "sso" feature for the aws-config dependency in Cargo.toml. As a result, the Cargo.lock file has been updated to include the aws-sdk-sso and aws-sdk-ssooidc packages, along with supporting dependencies such as hex, ring, and zeroize. I have no feedback to provide.

@jdx jdx merged commit 10aa691 into jdx:main May 15, 2026
32 checks passed
mise-en-dev added a commit that referenced this pull request May 16, 2026
### 🐛 Bug Fixes

- **(s3)** support SSO-based AWS profiles by enabling aws-config sso
feature by @Amir-Ahmad in [#9875](#9875)

### 🚜 Refactor

- **(backend)** parse tool options per backend by @risu729 in
[#9838](#9838)

### 📦️ Dependency Updates

- update rust crate sha2 to 0.11 by @renovate[bot] in
[#9885](#9885)
- update ghcr.io/jdx/mise:alpine docker digest to 1a653b5 by
@renovate[bot] in [#9890](#9890)
- update ghcr.io/jdx/mise:rpm docker digest to 7880c74 by @renovate[bot]
in [#9892](#9892)
- update ghcr.io/jdx/mise:deb docker digest to a6fe62d by @renovate[bot]
in [#9891](#9891)
- update rust docker digest to 39d8cb3 by @renovate[bot] in
[#9899](#9899)

### New Contributors

- @Amir-Ahmad made their first contribution in
[#9875](#9875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants