fix(s3): support SSO-based AWS profiles by enabling aws-config sso feature#9875
Conversation
This fixes an issue where you AWS authentication is broken if you use https://aws.amazon.com/iam/identity-center/
Greptile SummaryThis PR fixes AWS SSO (IAM Identity Center) authentication for S3 downloads by enabling the
Confidence Score: 5/5Safe to merge — the change is a single feature flag addition that unlocks an existing, well-tested AWS SDK code path. The fix is minimal and surgical: one line added to Cargo.toml, with a lock file update that only pulls in the two expected AWS SSO SDK crates. The pre-existing transitive dependencies (ring, hex, zeroize) were already in the tree, so binary size growth is limited to the SSO SDK itself. No logic changes, no API surface changes, no behaviour changes for non-SSO profiles. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Enable sso on aws-config features" | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request enables the "sso" feature for the aws-config dependency in Cargo.toml. As a result, the Cargo.lock file has been updated to include the aws-sdk-sso and aws-sdk-ssooidc packages, along with supporting dependencies such as hex, ring, and zeroize. I have no feedback to provide.
### 🐛 Bug Fixes - **(s3)** support SSO-based AWS profiles by enabling aws-config sso feature by @Amir-Ahmad in [#9875](#9875) ### 🚜 Refactor - **(backend)** parse tool options per backend by @risu729 in [#9838](#9838) ### 📦️ Dependency Updates - update rust crate sha2 to 0.11 by @renovate[bot] in [#9885](#9885) - update ghcr.io/jdx/mise:alpine docker digest to 1a653b5 by @renovate[bot] in [#9890](#9890) - update ghcr.io/jdx/mise:rpm docker digest to 7880c74 by @renovate[bot] in [#9892](#9892) - update ghcr.io/jdx/mise:deb docker digest to a6fe62d by @renovate[bot] in [#9891](#9891) - update rust docker digest to 39d8cb3 by @renovate[bot] in [#9899](#9899) ### New Contributors - @Amir-Ahmad made their first contribution in [#9875](#9875)
This fixes an issue where AWS authentication is broken if you use aws sso: https://aws.amazon.com/iam/identity-center/
Validation:
Have built the new binary and confirmed that AWS auth is now working for s3 downloads, fixes previous failure
S3 error: DispatchFailure(DispatchFailure { source: ConnectorError { kind: Other(None), source: InvalidConfiguration(InvalidConfiguration { source: "ProfileFile provider could not be built: This behavior requires following cargo feature(s) enabled: sso. " }), connection: Unknown } })