registry: Add Racket minimal distribution configuration#9784
Conversation
Greptile SummaryThis PR adds a minimal registry entry (
Confidence Score: 3/5The single changed file introduces a backend identifier ( The aqua backend identifier in the file conflicts with the package name recorded in the aqua-registry release notes; the identifier as written would cause every install attempt to fail. This point has been raised in earlier review rounds but is not yet addressed in the code, which keeps the change in a broken state. registry/racket.toml — the Important Files Changed
Reviews (5): Last reviewed commit: "Merge branch 'main' into add-racket" | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request adds a registry entry for the minimal Racket distribution, including its backend source and a version test. The reviewer suggested enhancing the configuration with aliases, file detection patterns, and idiomatic file definitions to improve tool discoverability and project detection within mise.
| backends = ["aqua:racket-lang.org/racket-minimal"] | ||
| description = "Minimal Racket distribution" | ||
| test = { cmd = "racket --version", expected = "Welcome to Racket v{{version}}" } |
There was a problem hiding this comment.
To improve the user experience and tool discoverability in mise, consider adding aliases, detect, and idiomatic_files to the registry configuration.
aliases: Allows users to install the tool usingracket-minimalas well.detect: Enablesmiseto suggest installing Racket when it detects.rktorinfo.rktfiles in a project.idiomatic_files: Helpsmiseidentify a directory as a Racket project wheninfo.rktis present.
| backends = ["aqua:racket-lang.org/racket-minimal"] | |
| description = "Minimal Racket distribution" | |
| test = { cmd = "racket --version", expected = "Welcome to Racket v{{version}}" } | |
| backends = ["aqua:racket-lang.org/racket-minimal"] | |
| aliases = ["racket-minimal"] | |
| description = "Minimal Racket distribution" | |
| detect = ["info.rkt", "*.rkt"] | |
| idiomatic_files = ["info.rkt"] | |
| test = { cmd = "racket --version", expected = "Welcome to Racket v{{version}}" } |
|
looks super janky: |
| @@ -0,0 +1,3 @@ | |||
| backends = ["aqua:racket/racket/minimal"] | |||
There was a problem hiding this comment.
The aqua backend identifier is incorrect. The aqua registry package added in aquaproj/aqua-registry#53232 (also referenced in the PR description) is named
racket-lang.org/racket-minimal, which means the mise identifier should be aqua:racket-lang.org/racket-minimal. The current value aqua:racket/racket/minimal does not correspond to any existing aqua package and will fail at install time. Existing domain-style aqua packages in this registry (e.g., aqua:atlassian.com/acli) confirm that the domain prefix must be included as-is.
| backends = ["aqua:racket/racket/minimal"] | |
| backends = ["aqua:racket-lang.org/racket-minimal"] |
|
Updated after aquaproj/aqua-registry#53580 |
|
make sure this actually works, I don't think it will based on this: |
|
It's because |
|
we do not pull versions from the aqua registry |
|
If I update |
| @@ -0,0 +1,3 @@ | |||
| backends = ["aqua:racket/racket/minimal"] | |||
There was a problem hiding this comment.
The aqua backend identifier
aqua:racket/racket/minimal does not match the package name in the aqua registry. The PR description links to aquaproj/aqua-registry#53232, which adds the package as racket-lang.org/racket-minimal. Other domain-prefixed aqua entries in this registry (e.g. aqua:atlassian.com/acli, aqua:getdbt.com/dbt-fusion) confirm the full domain must be included as-is. Using the wrong identifier will cause mise install racket to fail at runtime.
| backends = ["aqua:racket/racket/minimal"] | |
| backends = ["aqua:racket-lang.org/racket-minimal"] |
Adds a registry shorthand for Racket using the aqua package
racket/racket/minimal.This installs the minimal Racket distribution from official racket-lang.org release artifacts and exposes
racketandraco.The aqua package was originally added in aquaproj/aqua-registry#53232 and later renamed/fixed in aquaproj/aqua-registry#53580 to use the canonical package name
racket/racket/minimalwithrepo_owner = racketandrepo_name = racket.Verified locally:
Adds a registry shorthand for Racket using the aqua packageracket-lang.org/racket-minimal.This installs the minimal Racket distribution from official racket-lang.org release artifacts and exposes
racketandraco.rackethas been added to aqua in aquaproj/aqua-registry#53232.