fix(upgrade): remove completed progress jobs to prevent duplicate output

[jdx]

Summary

Fixes #9774 — mise upgrade (and its alias mise up) was printing the installed-tools block twice when it also needed to uninstall an old version.

Root cause

MultiProgressReport is a process-global singleton on top of clx's global JOBS registry.

1. install_all_versions calls mpr.init_footer(...) which pushes a header job + per-tool jobs into clx's JOBS. They run to completion and mpr.footer_finish() calls progress::stop(), which renders the final state and resets LINES = 0 but does not remove jobs from JOBS (the default ProgressJobDoneBehavior is Keep).
2. upgrade.rs then calls mpr.add("uninstall ..."). clx's background thread restarts, sees four jobs in JOBS (header + uv + python + uninstall), and renders them all. Because LINES = 0, the new render is appended below the previously-printed final state — producing the duplicate block reported.

Fix

Track every job created via add_with_options in MultiProgressReport, and in footer_finish call ProgressJob::remove() on each (plus the header) after progress::stop(). Subsequent mpr.add(...) calls then start from a clean JOBS list and render only the new job.

Test plan

• cargo build clean
• cargo clippy --bin mise -- -D warnings clean
• Manual: run mise upgrade against a tool that needs both an install and an uninstall — expect a single installed-tools block followed by the uninstall line
• Manual: confirm normal mise install and mise upgrade (no uninstalls) still render correctly

The bug only manifests when stderr is a real TTY (use_progress_ui = true), so the e2e harness can't easily assert on it.

🤖 Generated with Claude Code

---

Note

Low Risk
Low risk: changes are limited to progress UI lifecycle, clearing clx’s global job registry after completion/stop to prevent duplicated output; main impact is on terminal rendering behavior.

Overview
Prevents duplicated progress output across sequential operations by explicitly clearing clx’s global progress job list when a progress session ends.

MultiProgressReport now centralizes cleanup in reset_jobs(), called from both footer_finish() and stop(), which clears header state, resets counters, and calls progress::clear_jobs() so subsequent mpr.add(...) starts from a clean slate. Also bumps the clx dependency in Cargo.lock to 2.1.0.

^{Reviewed by Cursor Bugbot for commit 80ee4ef. Bugbot is set up for automated code reviews on this repo. Configure here.}

[greptile-apps]

Greptile Summary

This PR fixes a duplicate-output bug in mise upgrade where the installed-tools progress block was rendered twice when the upgrade also triggered an uninstall. The root cause was that progress::stop() and progress::stop_clear() left clx's global JOBS registry intact, so subsequent mpr.add() calls caused the render thread to re-emit previously completed jobs.

• Bumps clx from 2.0.3 to 2.1.0 to gain the new progress::clear_jobs() API, then extracts a reset_jobs() helper in MultiProgressReport that drops header_job, calls progress::clear_jobs(), and resets the session counters.
• Both footer_finish (which previously reset counters inline but never cleared clx's registry) and stop now delegate to reset_jobs(), ensuring the global JOBS list is clean before any subsequent install/uninstall progress session begins.
• The prior concern that stop() didn't clean up header_job is resolved in this version — both exit paths now go through the same reset_jobs() helper.

Confidence Score: 5/5

Safe to merge — the change is narrowly scoped to progress-state teardown and correctly handles all known exit paths.

The fix is clean and well-reasoned: reset_jobs() is called by both footer_finish and stop, clearing clx's global JOBS list and all session counters after each render cycle. The previous review concern about stop() not clearing header_job has been addressed. The only non-test code path affected by the global progress::clear_jobs() call is the MultiProgressReport singleton, which owns all progress reporting in the process.

No files require special attention.

Important Files Changed

Filename	Overview
src/ui/multi_progress_report.rs	Extracts reset_jobs() helper that calls progress::clear_jobs() (new in clx 2.1.0) to clear clx's global JOBS registry; both footer_finish and stop now call it, correctly clearing header_job and counters after each session
Cargo.lock	Bumps clx from 2.0.3 to 2.1.0 to gain the progress::clear_jobs() API used by the fix

_{Reviews (3): Last reviewed commit: "refactor(progress): use clx::progress::c..." | Re-trigger Greptile}

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to track and explicitly remove progress jobs within MultiProgressReport. By adding a tracked_jobs field and calling remove() on both the header and tracked jobs during the footer_finish phase, the changes ensure that completed jobs are not re-rendered during subsequent operations. Additionally, the visibility of the job field in ProgressReport was updated to pub(crate) to facilitate this tracking. I have no feedback to provide as there were no review comments.

[jdx]

Upstream alternative open at jdx/clx#94 — adds a small clear_jobs() primitive so this fix doesn't need a parallel tracking Vec on the mise side. Plan: once that lands and clx is released, I'll bump clx here and simplify this PR to call progress::clear_jobs() from the new reset_jobs() helper. Leaving this PR as-is in the meantime as the immediate fix.

This comment was generated by an AI coding assistant.

[github-actions]

Hyperfine Performance

mise x -- echo

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2026.5.6 x -- echo	19.1 ± 0.8	17.8	22.3	1.00
mise x -- echo	19.3 ± 1.4	17.3	27.8	1.01 ± 0.08

mise env

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2026.5.6 env	19.3 ± 1.1	17.1	24.1	1.03 ± 0.08
mise env	18.7 ± 1.1	16.8	23.2	1.00

mise hook-env

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2026.5.6 hook-env	20.2 ± 1.2	18.1	25.5	1.00
mise hook-env	21.2 ± 1.4	18.2	26.0	1.05 ± 0.10

mise ls

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
mise-2026.5.6 ls	16.8 ± 1.1	14.9	20.6	1.00
mise ls	18.1 ± 1.4	15.4	23.4	1.08 ± 0.11

xtasks/test/perf

Command	mise-2026.5.6	mise	Variance
install (cached)	129ms	132ms	-2%
ls (cached)	69ms	70ms	-1%
bin-paths (cached)	70ms	70ms	+0%
task-ls (cached)	484ms	478ms	+1%

[jdx]

Updated to use clx::progress::clear_jobs() now that clx#94 has shipped in clx v2.1.0. Dropped the mise-side tracked_jobs Vec and the pub(crate) widening of ProgressReport.job — both were only needed because clx didn't have a way to drain its global JOBS list externally.

As a bonus, the clx fix also resets the STOPPING flag, so a fresh session after stop() actually animates again (previously only the final terminal-state flush rendered, via the synchronous refresh_once() path that bypasses STOPPING). Doesn't change behavior here, but the "start a new session" pattern is now sound for anything that wants spinners or incremental updates after a stop.

This comment was generated by an AI coding assistant.