fix(tasks): refactor editor command handling and improve error reporting by roele · Pull Request #9752 · jdx/mise

roele · 2026-05-09T16:41:03Z

Fixes an issue mentioned in #9731 with EDITOR/VISUAL value using arguments.

greptile-apps · 2026-05-09T16:43:24Z

Greptile Summary

This PR fixes a bug where EDITOR/VISUAL values containing arguments (e.g. code --wait or "/Applications/My Editor.app/editor" --wait) were passed as a single program name to cmd!, causing the editor to fail to launch. The fix extracts a split_editor_command helper that uses the already-present shell_words crate to correctly parse the value before invoking the editor.

open_in_editor and split_editor_command replace the single cmd! call, cleanly separating the parsing logic from the invocation.
Three unit tests cover a simple program arg value, a quoted path with a space, and the empty-editor error path.

Confidence Score: 5/5

Safe to merge — the change is narrowly scoped to the editor invocation path and uses the already-present shell_words crate in a way consistent with the rest of the codebase.

The fix correctly addresses the root cause (whole-string program lookup instead of split invocation), reuses an existing well-tested dependency, and is covered by new unit tests. No regressions are introduced in the surrounding task creation or path-display logic.

No files require special attention.

Important Files Changed

Filename	Overview
src/cli/tasks/edit.rs	Refactors editor invocation to use shell_words::split so EDITOR/VISUAL values containing arguments (e.g. "code --wait") are parsed correctly; adds three unit tests covering the main cases.

_{Reviews (3): Last reviewed commit: "Merge branch 'main' into issues/9731" | Re-trigger Greptile}

Copilot

Pull request overview

Refactors mise tasks edit editor invocation to correctly handle EDITOR/VISUAL values that include arguments (fix for #9731) and improves associated error handling.

Changes:

Replace direct cmd!($EDITOR, file) invocation with open_in_editor() that splits the editor command into program + args.
Add split_editor_command() using shell_words::split and introduce an explicit error for empty EDITOR/VISUAL.
Add a unit test covering editor values with arguments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

gemini-code-assist

Code Review

This pull request enhances the task editing functionality by correctly parsing the EDITOR environment variable when it contains arguments. It introduces a helper function split_editor_command using shell_words and adds corresponding unit tests. Review feedback suggests refactoring the variable assignment for better conciseness and using an iterator-based approach in split_editor_command to improve efficiency and idiomaticity.

# Problem While trying to understand an issue with the value of VISUAL in `mise -v tasks edit <task>` (see jdx#9731, already addressed by PR jdx#9752), I found the `debug!` message generated by `cmd::cmd(..)` to be less helpful than it could be. With `VISUAL='cat -n'`, the following information got logged: ``` log ... DEBUG $ cat -n /home/kt/work/oss/mise/tasks.toml Error: 0: No such file or directory (os error 2) ... ``` Here, `cat -n` was interpreted as the program to execute. However, the `DEBUG:` line, doesn't show that. # Solution Add single-qu While trying to understand an issue with the value of VISUAL in `mise -v tasks edit <task>` (see jdx#9731, already addressed by PR jdx#9752), I found the `debug!` message generated by `cmd::cmd(..)` to be less helpful than it could be. With `VISUAL='cat -n'`, the following information got logged: ``` log ... DEBUG $ cat -n /home/kt/work/oss/mise/tasks.toml Error: 0: No such file or directory (os error 2) ... ``` Here, `cat -n` was interpreted as the program to execute. However, the `DEBUG:` line, doesn't show that. # Solution Add single-quotes around `program` and `args` when generating the `debug!` message. This changes the logged information to: ```log ... DEBUG $ 'cat -n' '/home/kt/work/oss/mise/tasks.toml' Error: 0: No such file or directory (os error 2) ... ``` This clearly shows the reason for the following error message. Note: The `Error` reported by `duct::cmd(..)`: ```log Error: 0: No such file or directory (os error 2) ``` is also not helpful. This [issue from 2023 in the *duct repository*](oconnor663/duct.rs#109) describes that problem (and would potentially solve the issue addressed by this PR). But so far, nobody stepped up to provide a fix.

# Problem While trying to understand an issue with the value of VISUAL in `mise -v tasks edit <task>` (see jdx#9731, already addressed by PR jdx#9752), I found the `debug!` message generated by `cmd::cmd(..)` to be less helpful than it could be. With `VISUAL='cat -n'`, the following information got logged: ``` log ... DEBUG $ cat -n /home/kt/work/oss/mise/tasks.toml Error: 0: No such file or directory (os error 2) ... ``` Here, `cat -n` was interpreted as the program to execute. However, the `DEBUG ...` line, doesn't show that. # Solution Add single-quotes around `program` and `args` when generating the `debug!` message. This changes the logged information to: ```log ... DEBUG $ 'cat -n' '/home/kt/work/oss/mise/tasks.toml' Error: 0: No such file or directory (os error 2) ... ``` This hopefully helps to understand the reason for the following error message (from `duct::cmd(..)`). --- Note: The error reported by `duct::cmd(..)`: ```log Error: 0: No such file or directory (os error 2) ``` also leaves room for improvement. This was already discussed in this [issue from 2023 in the *duct repository*](oconnor663/duct.rs#109) and would potentially solve the issue addressed by this commit/PR. But so far, nobody stepped up to provide a fix.

# Problem While trying to understand an issue with the value of VISUAL in `mise -v tasks edit <task>` (see jdx#9731, already addressed by PR jdx#9752), I found the `debug!` message generated by `cmd::cmd(..)` to be less helpful than it could be. With `VISUAL='cat -n'`, the following information got logged: ``` log ... DEBUG $ cat -n /home/kt/work/oss/mise/tasks.toml Error: 0: No such file or directory (os error 2) ... ``` Here, `cat -n` was interpreted as the program to execute. However, the `DEBUG ...` line, doesn't show that. # Solution Add single-quotes around `program` and `args` when generating the `debug!` message. This changes the logged information to: ```log ... DEBUG $ 'cat -n' '/home/kt/work/oss/mise/tasks.toml' Error: 0: No such file or directory (os error 2) ... ``` This hopefully helps to understand the reason for the following error message (from `duct::cmd(..)`). --- Note: The error reported by `duct::cmd(..)`: ```log Error: 0: No such file or directory (os error 2) ``` also leaves room for improvement. This was already discussed in [issue 109 (Include the command that failed in the error)](oconnor663/duct.rs#109) from 2023 in the *duct.rs repository*. A fix for this issue would potentially solve the problem addressed by this commit/PR. But so far, nobody stepped up to provide that fix.

# Problem While trying to understand an issue with the value of VISUAL in `mise -v tasks edit <task>` (see jdx#9731, already addressed by PR jdx#9752), I found the `debug!` message generated by `cmd::cmd(..)` to be less helpful than it could be. With `VISUAL='cat -n'`, the following information got logged: ``` log ... DEBUG $ cat -n /home/kt/work/oss/mise/tasks.toml Error: 0: No such file or directory (os error 2) ... ``` Here, `cat -n` was interpreted as the program to execute. However, the `DEBUG ...` line, doesn't show that. # Solution Use shell_escape::escape on `program` and `args` when generating the `debug!` message. This changes the logged information to: ```log ... DEBUG $ 'cat -n' /home/kt/work/oss/mise/tasks.toml Error: 0: No such file or directory (os error 2) ... ``` This hopefully helps to understand the reason for the following error message (from `duct::cmd(..)`). --- Note: The error reported by `duct::cmd(..)`: ```log Error: 0: No such file or directory (os error 2) ``` also leaves room for improvement. This was already discussed in [issue 109 (Include the command that failed in the error)](oconnor663/duct.rs#109) from 2023 in the *duct.rs repository*. A fix for this issue would potentially solve the problem addressed by this commit/PR. But so far, nobody stepped up to provide that fix.

# Problem While trying to understand an issue with the value of VISUAL in `mise -v tasks edit <task>` (see jdx#9731, already addressed by PR jdx#9752), I found the `debug!` message generated by `cmd::cmd(..)` to be less helpful than it could be. With `VISUAL='cat -n'`, the following information got logged: ``` log ... DEBUG $ cat -n /home/kt/work/oss/mise/tasks.toml Error: 0: No such file or directory (os error 2) ... ``` Here, `cat -n` was interpreted as the program to execute. However, the `DEBUG ...` line, doesn't show that. # Solution Call `shell_escape::escape(..)` on `program` and `args` when generating the `debug!` message. This changes the logged information to: ```log ... DEBUG $ 'cat -n' /home/kt/work/oss/mise/tasks.toml Error: 0: No such file or directory (os error 2) ... ``` This hopefully helps to understand the reason for the following error message (from `duct::cmd(..)`). --- Note: The error reported by `duct::cmd(..)`: ```log Error: 0: No such file or directory (os error 2) ``` also leaves room for improvement. This was already discussed in [issue 109 (Include the command that failed in the error)](oconnor663/duct.rs#109) from 2023 in the *duct.rs repository*. A fix for this issue would potentially solve the problem addressed by this commit/PR. But so far, nobody stepped up to provide that fix.

…9777) # Problem While trying to understand an issue with the value of VISUAL in `mise -v tasks edit <task>` (see #9731, already addressed by PR #9752), I found the `debug!` message generated by `cmd::cmd(..)` to be less helpful than it could be. With `VISUAL='cat -n'`, the following information got logged: ``` log ... DEBUG $ cat -n /home/kt/work/oss/mise/tasks.toml Error: 0: No such file or directory (os error 2) ... ``` Here, `cat -n` was interpreted as the program to execute. However, the `DEBUG ...` line, doesn't show that. # Solution Call `shell_escape::escape(..)` on `program` and `args` when generating the `debug!` message. This changes the logged information to: ```log ... DEBUG $ 'cat -n' /home/kt/work/oss/mise/tasks.toml Error: 0: No such file or directory (os error 2) ... ``` This hopefully helps to understand the reason for the following error message from `duct::cmd(..)`). --- Note: The error reported by `duct::cmd(..)`: ```log Error: 0: No such file or directory (os error 2) ``` also leaves room for improvement. This was already discussed in [issue 109: Include the command that failed in the error](oconnor663/duct.rs#109) from 2023 in the *duct.rs repository*. A fix for this issue would potentially solve the problem addressed by this commit/PR. But so far, nobody stepped up to provide that fix.

Copilot AI review requested due to automatic review settings May 9, 2026 16:41

Copilot started reviewing on behalf of roele May 9, 2026 16:41 View session

greptile-apps Bot reviewed May 9, 2026

View reviewed changes

Comment thread src/cli/tasks/edit.rs Outdated

Comment thread src/cli/tasks/edit.rs

Copilot AI reviewed May 9, 2026

View reviewed changes

Comment thread src/cli/tasks/edit.rs Outdated

Comment thread src/cli/tasks/edit.rs Outdated

gemini-code-assist Bot reviewed May 9, 2026

View reviewed changes

Comment thread src/cli/tasks/edit.rs Outdated

Comment thread src/cli/tasks/edit.rs

fix(tasks): refactor editor command handling and improve error reporting

093f89a

roele force-pushed the issues/9731 branch from b677ad8 to 093f89a Compare May 9, 2026 16:51

Merge branch 'main' into issues/9731

fcfaeab

ktetzlaff mentioned this pull request May 11, 2026

fix: quote program and args in debug message from cmd::cmd(..) #9777

Merged

jdx merged commit 7dbaa1d into jdx:main Jun 12, 2026
33 checks passed

mise-en-dev mentioned this pull request Jun 12, 2026

chore: release 2026.6.4 #10322

Merged

BrewTestBot mentioned this pull request Jun 12, 2026

mise 2026.6.4 Homebrew/homebrew-core#287663

Merged

roele deleted the issues/9731 branch June 12, 2026 17:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(tasks): refactor editor command handling and improve error reporting#9752

fix(tasks): refactor editor command handling and improve error reporting#9752
jdx merged 2 commits into
jdx:mainfrom
roele:issues/9731

roele commented May 9, 2026

Uh oh!

greptile-apps Bot commented May 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

roele commented May 9, 2026

Uh oh!

greptile-apps Bot commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

greptile-apps Bot commented May 9, 2026 •

edited

Loading