Skip to content

test(zig): use official zig instead of mach mirror #9659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 2 commits into from
May 6, 2026
Merged

test(zig): use official zig instead of mach mirror #9659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1210ef6
test(zig): use official zig instead of mach mirror
jdx May 6, 2026
53a0b3d
test(zig): drop redundant zig 0.14.0 case
jdx May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions e2e-win/zig.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,4 @@ Describe 'zig' {
It 'executes zig 0.13.0' {
mise x zig@0.13.0 -- zig version | Should -be "0.13.0"
}

@cursor cursor Bot May 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacement zig@0.14.0 test cases never added

Medium Severity

The PR description states it replaces the mach test cases with zig@0.14.0 and claims coverage of "two distinct released Zig versions (0.13.0, 0.14.0) plus master." However, only the mach cases were removed — no zig@0.14.0 assertions were added to either e2e-win/zig.Tests.ps1 or e2e/core/test_zig_slow. This reduces test coverage from what was intended.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 53a0b3d. Configure here.

It 'executes zig 2024.11.0-mach' {
mise x zig@2024.11.0-mach -- zig version | Should -be "0.14.0-dev.2577+271452d22"
}
}
2 changes: 0 additions & 2 deletions e2e/core/test_zig_slow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,3 @@

assert "mise x zig@0.13.0 -- zig version" "0.13.0"
assert "mise x zig@master -- zig version"
Comment on lines 3 to 4

@greptile-apps greptile-apps Bot May 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 The PR description says the mach assertions are replaced by zig@0.14.0, and states "We still cover two distinct released Zig versions (0.13.0, 0.14.0) plus master." However, no zig@0.14.0 assertion was actually added — the mach lines were simply removed. The intended replacement is missing.

Suggested change
assert "mise x zig@0.13.0 -- zig version" "0.13.0"
assert "mise x zig@master -- zig version"
assert "mise x zig@0.13.0 -- zig version" "0.13.0"
assert "mise x zig@0.14.0 -- zig version" "0.14.0"
assert "mise x zig@master -- zig version"

Fix in Claude Code

assert "mise x zig@2024.11.0-mach -- zig version" "0.14.0-dev.2577+271452d22"
assert "mise x zig@mach-latest -- zig version"
Loading