Skip to content

fix(backend): suppress no-versions warning for unresolved-latest backends #9548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
May 2, 2026
Merged

fix(backend): suppress no-versions warning for unresolved-latest backends #9548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/backend/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,7 +854,10 @@ pub trait Backend: Debug + Send + Sync {
}
})
.collect_vec();
if versions.is_empty() && self.get_type() != BackendType::Http {
if versions.is_empty()
&& self.get_type() != BackendType::Http
&& self.unresolved_latest_version().is_none()
{
Comment on lines +857 to +860
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The check for BackendType::Http appears to be missing BackendType::S3, which is typically handled similarly in this module (e.g., line 723). Since S3 backends can also function without a remote version list (e.g., when using direct URLs), they should likely also be excluded from this warning to avoid unnecessary log noise.

Suggested change
if versions.is_empty()
&& self.get_type() != BackendType::Http
&& self.unresolved_latest_version().is_none()
{
if versions.is_empty()
&& !matches!(self.get_type(), BackendType::Http | BackendType::S3)
&& self.unresolved_latest_version().is_none()
{

warn!("No versions found for {id}");
}
Ok(versions)
Expand Down
Loading