Skip to content

fix(install): don't warn for configured tools when version is passed via CLI #9522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 6 commits into from
May 1, 2026
Merged

fix(install): don't warn for configured tools when version is passed via CLI #9522

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee96be0
fix(install): don't warn for configured tools when version is passed …
jdx May 1, 2026
172ea20
refactor(install): drop intermediate Vec and reuse tools set
jdx May 1, 2026
66dbf87
fix(install): also treat MISE_<TOOL>_VERSION env vars as activating
jdx May 1, 2026
e956054
refactor(toolset): extract tool_env_vars helper
jdx May 1, 2026
4d54b4d
fix(install): unalias env-var-derived tool names
jdx May 1, 2026
516d513
test(install): cover env-var unaliasing in unit tests, drop dead e2e …
jdx May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions e2e/cli/test_install_inactive_hint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,12 @@ assert_contains "mise install tiny@3.1.0 2>&1" "mise use tiny"
mise use dummy@1.0.0
assert_not_contains "mise install dummy 2>&1" "not activated"

# Test: Installing TOOL@VERSION for a tool that IS in config should NOT show
# the hint (regression test for #9501 — CLI args were overriding the config
# source in the merged tool request set, falsely flagging configured tools as
# inactive).
assert_not_contains "mise install dummy@1.0.0 2>&1" "not activated"
assert_not_contains "mise install dummy@latest 2>&1" "not activated"

# Clean up
mise use --rm dummy
22 changes: 16 additions & 6 deletions src/cli/install.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,14 +147,24 @@ impl Install {
.iter()
.map(|ta| ta.ba.short.clone())
.collect();
// Collect inactive tool names before trs borrow is consumed
// Collect set of tools that appear in any config file. We can't use
// trs.sources here because load_runtime_args overrides the config-derived
// source with ToolSource::Argument whenever the user passes TOOL@VERSION.
let configured_tools: HashSet<String> = config
.config_files
.values()
.filter_map(|cf| cf.to_tool_request_set().ok())
.flat_map(|cf_trs| {
cf_trs
.tools
.keys()
.map(|ba| ba.short.clone())
.collect::<Vec<_>>()
})

@gemini-code-assist gemini-code-assist Bot May 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The intermediate Vec allocation inside flat_map is unnecessary. You can chain the iterator directly to improve efficiency and readability.

            .flat_map(|cf_trs| cf_trs.tools.keys().map(|ba| ba.short.clone()))

.collect();
Comment thread
cursor[bot] marked this conversation as resolved.
let inactive_tools: Vec<String> = expanded_runtimes
.iter()
.filter(|ta| {
trs.sources
.get(ta.ba.as_ref())
.is_none_or(|s| s.is_argument())
})
.filter(|ta| !configured_tools.contains(&ta.ba.short))
.map(|ta| ta.ba.short.clone())
.collect();

@gemini-code-assist gemini-code-assist Bot May 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the tools set (containing the names of tools being installed) is already computed at line 146, you can use it directly to calculate inactive_tools. This avoids re-iterating over expanded_runtimes and automatically handles duplicate tool names in the warning message (e.g., if a user runs mise install node@20 node@22).

Suggested change
let inactive_tools: Vec<String> = expanded_runtimes
.iter()
.filter(|ta| {
trs.sources
.get(ta.ba.as_ref())
.is_none_or(|s| s.is_argument())
})
.filter(|ta| !configured_tools.contains(&ta.ba.short))
.map(|ta| ta.ba.short.clone())
.collect();
let inactive_tools: Vec<String> = tools
.iter()
.filter(|t| !configured_tools.contains(*t))
.cloned()
.collect();

let mut ts: Toolset = trs.filter_by_tool(tools).into();
Expand Down
Loading