Conversation
Greptile SummaryAutomated release PR bumping mise from Confidence Score: 5/5Safe to merge — standard automated release PR with consistent version bumps and registry package updates All version strings are consistently updated across every packaging artifact. Registry changes follow established patterns and include backward-compatible aliases for the pitchfork rename. The only minor concern is one unusual asset name pattern in the versitygw v0.14 entry, which may be intentional given the associated comment about broken checksums for that release. No P0 or P1 issues found. crates/aqua-registry/aqua-registry/registry.yaml — the versitygw v0.14 asset name pattern warrants a quick sanity check Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Release PR: 2026.4.27"] --> B["Version Bumps"]
A --> C["Aqua Registry Update\n(v4.499.0 → v4.501.0)"]
B --> B1["Cargo.toml / Cargo.lock"]
B --> B2["default.nix"]
B --> B3["RPM spec / snapcraft.yaml"]
B --> B4["Completions spec cache names"]
B --> B5["README.md example output"]
C --> D["New Packages (7)"]
C --> E["Updated Packages (5)"]
D --> D1["IohannRabeson/tmignore-rs"]
D --> D2["endevco/pitchfork\n(was jdx/pitchfork, alias added)"]
D --> D3["google/google-java-format"]
D --> D4["jonwiggins/xmloxide"]
D --> D5["matthart1983/netwatch"]
D --> D6["solarwinds/swo-cli"]
D --> D7["versity/versitygw"]
E --> E1["WebAssembly/wabt\n(YAML anchor expansion + new ≥1.0.39 override)"]
E --> E2["bmf-san/ggc\n(new version constraints + cosign)"]
E --> E3["lycheeverse/lychee\n(additional version splits)"]
E --> E4["pnpm/pnpm\n(new tar.gz format for latest)"]
E --> E5["tstack/lnav\n(Windows path fix: .exe removed)"]
Reviews (11): Last reviewed commit: "[autofix.ci] apply automated fixes" | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request updates mise to version 2026.4.27 and aqua-registry to v4.501.0, including a bug fix for empty version list caching and an update to the repository star count. While mise.lock was updated to include comprehensive platform support for Node.js, a potential regression was identified where the Node.js version was downgraded from 25.9.0 to 24.14.0.
|
|
||
| [[tools.node]] | ||
| version = "25.9.0" | ||
| version = "24.14.0" |
There was a problem hiding this comment.
The Node.js version has been downgraded from 25.9.0 to 24.14.0. While this release adds comprehensive platform support to the lockfile, this version change appears to be a regression or an unintended side effect of the lockfile generation process, as it is not mentioned in the pull request description. If Node.js 25 was intended to be the target version, please ensure the lockfile reflects that across all platforms.
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.25 x -- echo |
21.5 ± 0.3 | 20.0 | 24.0 | 1.00 |
mise x -- echo |
22.2 ± 0.7 | 21.5 | 28.7 | 1.03 ± 0.03 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.25 env |
21.4 ± 0.9 | 20.5 | 29.9 | 1.00 |
mise env |
21.7 ± 0.6 | 20.8 | 28.3 | 1.01 ± 0.05 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.25 hook-env |
22.1 ± 0.8 | 21.2 | 28.1 | 1.00 |
mise hook-env |
22.4 ± 0.7 | 21.7 | 32.9 | 1.01 ± 0.05 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.25 ls |
22.1 ± 0.3 | 21.2 | 25.1 | 1.00 |
mise ls |
22.8 ± 0.4 | 21.7 | 25.0 | 1.03 ± 0.02 |
xtasks/test/perf
| Command | mise-2026.4.25 | mise | Variance |
|---|---|---|---|
| install (cached) | 153ms | 155ms | -1% |
| ls (cached) | 78ms | 80ms | -2% |
| bin-paths (cached) | 79ms | 81ms | -2% |
| task-ls (cached) | 789ms | 792ms | +0% |
## Summary - Replace the PR-comment step in `vendored-file-warning.yml` with a plain failing status check, dropping the need for `MISE_PR_COMMENT_TOKEN` and `pull_request_target`. - Switch the skip condition from `github.actor` to `github.event.pull_request.user.login` so re-triggers from bots like `autofix-ci` on release PRs (opened by `mise-en-dev`) don't run the job. Both fix the failing check seen on [#9463](#9463), where `autofix-ci[bot]` re-triggered the workflow on a release PR and the comment step then errored with `Resource not accessible by personal access token (addComment)`. ## Test plan - [ ] Verify this PR's own checks pass (vendored-file-warning should not trigger — no aqua-registry files are touched). - [ ] On the next aqua-registry sync PR opened by `mise-en-dev`, confirm the workflow is skipped. - [ ] On a contributor PR that edits `crates/aqua-registry/aqua-registry/**`, confirm the check fails with the explanatory log message. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > CI-only workflow change with no production code impact; main risk is unintended job triggering/skipping due to the updated event and allowlist condition. > > **Overview** > Switches the `vendored-file-warning` workflow from `pull_request_target` to `pull_request` and replaces the PR-commenting behavior (and required token) with a simple failing check that prints guidance when vendored `crates/aqua-registry/aqua-registry/**` files are modified. > > Updates the skip condition to key off `github.event.pull_request.user.login` (instead of `github.actor`) so bot re-runs don’t bypass the intended allowlist for `jdx`/`mise-en-dev`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a4446d1. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
651cd73 to
c6e8b76
Compare
🚀 Features
config_rootavailable to environment plugins for relative path resolution by @hisaac in #9465🐛 Bug Fixes
Chore
New Contributors
📦 Aqua Registry Updates
New Packages (7)
IohannRabeson/tmignore-rsendevco/pitchforkgoogle/google-java-formatjonwiggins/xmloxidematthart1983/netwatchsolarwinds/swo-cliversity/versitygwUpdated Packages (5)
WebAssembly/wabtbmf-san/ggclycheeverse/lycheepnpm/pnpmtstack/lnav