-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
docs(site): add self-hosted page tracker via Cloudflare Worker, drop GoatCounter #9430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
e046d21
5bb438c
75f0bc6
bf02c04
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -359,29 +359,21 @@ export default withMermaid( | |
| rel: "stylesheet", | ||
| }, | ||
| ], | ||
| // Analytics | ||
| // Analytics (Plausible via Cloudflare Worker proxy) | ||
| [ | ||
| "script", | ||
| { | ||
| async: "", | ||
| src: "https://www.googletagmanager.com/gtag/js?id=G-B69G389C8T", | ||
| src: "https://shrill-1.en.dev/shrill/script.js", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Plausible script requires a "data-domain": "mise.jdx.dev",
"data-api": "https://shrill-1.en.dev/f5f1/event",
src: "https://shrill-1.en.dev/shrill/script.js", |
||
| }, | ||
| ], | ||
| [ | ||
| "script", | ||
| {}, | ||
| `window.dataLayer = window.dataLayer || []; | ||
| function gtag(){dataLayer.push(arguments);} | ||
| gtag('js', new Date()); | ||
| gtag('config', 'G-B69G389C8T');`, | ||
| ], | ||
| [ | ||
| "script", | ||
| { | ||
| "data-goatcounter": "https://jdx.goatcounter.com/count", | ||
| async: "", | ||
| src: "//gc.zgo.at/count.js", | ||
| }, | ||
| `window.plausible=window.plausible||function(){(plausible.q=plausible.q||[]).push(arguments)},plausible.init=plausible.init||function(i){plausible.o=i||{}}; | ||
| plausible.init({ | ||
| endpoint: "https://shrill-1.en.dev/f5f1/event" | ||
| })`, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This manual initialization script is non-standard for the official Plausible script and is missing the required `window.plausible = window.plausible || function() { (window.plausible.q = window.plausible.q || []).push(arguments) }` |
||
| ], | ||
| // OpenGraph | ||
| ["meta", { property: "og:site_name", content: "mise-en-place" }], | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTM scripts not removed despite stated intent
High Severity
The PR intended to replace Google Tag Manager (GTM) and GoatCounter with Plausible. While GoatCounter was removed, the GTM scripts (loader and inline
gtag()initialization) remain in theheadarray. This results in dual analytics tracking, with both GTM and Plausible firing.Reviewed by Cursor Bugbot for commit bf02c04. Configure here.