Skip to content

feat(aqua): compress baked registry blobs with zstd #9131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
risu729 wants to merge 22 commits into from
Closed

feat(aqua): compress baked registry blobs with zstd #9131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b8bf855
refactor(backend): bake aqua registry from merged yaml
risu729 Apr 11, 2026
262e51c
chore(aqua): restore vendored pkgs
risu729 Apr 11, 2026
22c9862
refactor(aqua): generate baked registry maps
risu729 Apr 11, 2026
29ee7ca
refactor(aqua): preserve static package ids
risu729 Apr 11, 2026
aee1531
docs(aqua): describe upstream registry
risu729 Apr 11, 2026
0ad3164
chore(aqua): remove stale vendored attribute
risu729 Apr 11, 2026
3b814f8
refactor(aqua): use direct registry count
risu729 Apr 11, 2026
4fd6231
refactor(aqua): avoid package alias type
risu729 Apr 11, 2026
3a3d8c5
chore(aqua): pin registry release tag
risu729 Apr 11, 2026
60ccfef
chore(aqua): clarify registry changelog source
risu729 Apr 11, 2026
d91441b
chore(aqua): link registry changelog tags
risu729 Apr 11, 2026
e856da9
chore(aqua): link registry changelog authors
risu729 Apr 11, 2026
cf5b2dd
chore(aqua): keep registry changelog authors
risu729 Apr 11, 2026
b7940f4
chore(aqua): list included registry releases
risu729 Apr 11, 2026
77e2b68
feat(aqua): expose baked registry metadata
risu729 Apr 11, 2026
916eccf
refactor(aqua): return results from registry build script
risu729 Apr 11, 2026
f5486c1
refactor(aqua): use eyre in registry build script
risu729 Apr 11, 2026
dabfb14
chore(aqua): warn on vendored registry changes
risu729 Apr 11, 2026
b051f6c
test(aqua): avoid hardcoded registry metadata tag
risu729 Apr 12, 2026
357b19c
fix(aqua): preserve path-only baked packages
risu729 Apr 12, 2026
e77a5ac
Merge branch 'main' into codex/aqua-baked-registry-yaml
risu729 Apr 15, 2026
4847185
feat(aqua): compress baked registry blobs with zstd
risu729 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
zipsign.pub binary
aqua-registry/ linguist-vendored
crates/aqua-registry/aqua-registry/** linguist-vendored
4 changes: 2 additions & 2 deletions .github/workflows/vendored-file-warning.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: vendored-file-warning
on:
pull_request_target:
paths:
- "crates/aqua-registry/aqua-registry/pkgs/**"
- "crates/aqua-registry/aqua-registry/**"

permissions: {}

Expand All @@ -23,7 +23,7 @@ jobs:
if [ "$existing" = "0" ]; then
gh pr comment "${{ github.event.pull_request.number }}" \
-R "${{ github.repository }}" \
--body "The aqua registry YAML files under \`crates/aqua-registry/\` are vendored from the upstream [aqua-registry](https://github.com/aquaproj/aqua-registry) and should not be modified directly in this repo. Please submit the package definitions to the upstream aqua-registry instead, and they will be picked up here when we next update the vendored copy.
--body "The aqua registry files under \`crates/aqua-registry/aqua-registry/\` are vendored from the upstream [aqua-registry](https://github.com/aquaproj/aqua-registry) and should not be modified directly in this repo. Please submit package definition changes to the upstream aqua-registry instead, and they will be picked up here when we next update the vendored copy.

The \`registry/*.toml\` files are fine to add here, but the backend should reference the package after it's been accepted upstream."
fi
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion crates/aqua-registry/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ include = [
"/README.md",
"/build.rs",
"/src/**/*.rs",
"/aqua-registry/pkgs/**/registry.yaml",
"/aqua-registry/LICENSE",
"/aqua-registry/metadata.json",
"/aqua-registry/registry.yaml",
]

[package.metadata.cargo-machete]
Expand Down Expand Up @@ -45,10 +47,13 @@ tokio = { version = "1", features = ["sync"] }

# Logging
log = "0.4"
zstd = "0.13"

Comment on lines +50 to 51

@greptile-apps greptile-apps Bot Apr 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 zstd grouped under # Logging comment

zstd is placed directly after log = "0.4" under the # Logging section header, which will confuse future readers looking for compression-related dependencies.

Suggested change
zstd = "0.13"
# Logging
log = "0.4"
# Compression
zstd = "0.13"

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


[dev-dependencies]
tokio = { version = "1", features = ["rt", "macros"] }

[build-dependencies]
eyre = "0.6"
serde_yaml = "0.9"
zstd = "0.13"
4 changes: 4 additions & 0 deletions crates/aqua-registry/aqua-registry/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"repository": "aquaproj/aqua-registry",
"tag": "v4.492.0"
}
Loading
Loading