Skip to content

fix: add windows support for usage tool registry #8713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 3 commits into from
Mar 22, 2026
Merged

fix: add windows support for usage tool registry #8713

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8112e11
fix: add windows support for usage tool registry
jdx Mar 22, 2026
39c5548
fix: remove os restriction entirely for usage tool
jdx Mar 22, 2026
7a89647
[autofix.ci] apply automated fixes
autofix-ci[bot] Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions registry/usage.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
backends = [
{ full = "aqua:jdx/usage", platforms = [
"linux",
"macos",
] },

@cursor cursor Bot Mar 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed os field instead of adding windows to it

Low Severity

The PR description says "Add windows to the top-level os list" but the os field was removed entirely instead of being changed to os = ["linux", "macos", "freebsd", "windows"]. Since is_supported_os() treats an empty os slice as "all platforms supported," the tool is now advertised as available on every OS (e.g., openbsd, netbsd), not just the four intended ones. The cargo:usage-cli fallback mitigates practical impact, but the tool's stated platform support is broader than intended.

Fix in Cursor Fix in Web

"aqua:jdx/usage",

@gemini-code-assist gemini-code-assist Bot Mar 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing the platform restrictions enables Windows support, it makes the aqua backend available on all platforms. This could cause issues on platforms like freebsd if aqua:jdx/usage does not provide binaries for it. Users on freebsd would have previously used the cargo backend, but will now try to use aqua and potentially fail.

To be more precise and avoid potential issues, it's better to explicitly list the supported platforms.

Suggested change
"aqua:jdx/usage",
{ full = "aqua:jdx/usage", platforms = [
"linux",
"macos",
"windows"
] },

{ full = "asdf:mise-plugins/mise-usage", platforms = [
"linux",
"macos",
] },
"cargo:usage-cli",
]
description = "A specification for CLIs"
os = ["linux", "macos", "freebsd"]
test = { cmd = "usage --version", expected = "usage-cli {{version}}" }
Loading