Skip to content

fix(install): skip GitHub API calls for aqua tools in --locked mode #8679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
Mar 21, 2026
Merged

fix(install): skip GitHub API calls for aqua tools in --locked mode #8679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/backend/aqua.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,10 @@ impl Backend for AquaBackend {
// Validate lockfile URL matches expected asset pattern from registry
// This handles cases where the registry format changed (e.g., raw binary -> tar.gz)
// Only validate for GithubRelease packages - other types use fixed URL formats
// In locked mode, trust the lockfile URL without validation to avoid API calls
let validated_url = if let Some(ref url) = existing_platform {
if pkg.r#type != AquaPackageType::GithubRelease {
existing_platform // Skip validation for non-release package types
if ctx.locked || pkg.r#type != AquaPackageType::GithubRelease {
existing_platform // Trust lockfile URL in locked mode or for non-release types
} else {
let cached_filename = get_filename_from_url(url);
let cached_filename_lower = cached_filename.to_lowercase();
Expand Down Expand Up @@ -399,6 +400,12 @@ impl Backend for AquaBackend {
tv.version.clone()
};
(url, v, filename, None)
} else if ctx.locked {
bail!(
"No lockfile URL found for {} on platform {} (--locked mode requires pre-resolved URLs)",
self.id,
platform_key
);
} else {
let (url, v, digest) = if let Some(v_prefixed) = v_prefixed {
// Try v-prefixed version first because most aqua packages use v-prefixed versions
Expand Down
Loading