chore(deps): update aws-lc-rs/aws-lc-sys and rustls-webpki#8674
Conversation
- Update aws-lc-rs 1.15.4 -> 1.16.2 and aws-lc-sys 0.37.0 -> 0.39.0 to fix RUSTSEC-2026-0044 through RUSTSEC-2026-0048 - Update rustls-webpki 0.103.9 -> 0.103.10 to fix RUSTSEC-2026-0049 - Ignore RUSTSEC-2026-0049 for rustls-webpki 0.101.7 (pinned by rustls 0.21 in aws-smithy-http-client, no safe upgrade available) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the project's security by updating several key dependencies in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Greptile SummaryThis PR is a targeted security dependency update that resolves RUSTSEC-2026-0044 through 0048 (via
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Fixed["✅ Fixed by this PR"]
ALS["aws-lc-rs 1.16.2\n+ aws-lc-sys 0.39.0\n(RUSTSEC-2026-0044..0048)"]
RWP["rustls-webpki 0.103.10\n(RUSTSEC-2026-0049)"]
end
subgraph Suppressed["⚠️ Suppressed in deny.toml"]
RWP_OLD["rustls-webpki 0.101.7\n(RUSTSEC-2026-0049)\nno upstream fix available"]
end
subgraph Chain["Pinned dependency chain"]
SMITHY["aws-smithy-http-client"] --> RUSTLS21["rustls 0.21"] --> RWP_OLD
end
RWP --> RUSTLS23["rustls 0.23.x (modern TLS path)"]
ALS --> RWP
Last reviewed commit: "chore(deps): update ..." |
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies to address multiple security vulnerabilities. The changes primarily involve updating Cargo.lock and adding an ignore rule to deny.toml. My review found a significant typo in the RUSTSEC advisory ID being ignored, which would make the rule ineffective. I've provided a correction and suggested adding a link to the upstream issue for better maintainability.
| { id = "RUSTSEC-2024-0370", reason = "proc-macro-error dependency from sigstore crate - no safe upgrade available" }, | ||
| { id = "RUSTSEC-2023-0071", reason = "rsa crate Marvin attack vulnerability from sigstore crate - no safe upgrade available" }, | ||
| { id = "RUSTSEC-2025-0119", reason = "number_prefix crate is unmaintained - used by indicatif/self_update, no safe upgrade available" }, | ||
| { id = "RUSTSEC-2026-0049", reason = "rustls-webpki 0.101.7 via rustls 0.21 in aws-smithy-http-client - no safe upgrade available" }, |
There was a problem hiding this comment.
There's a typo in the RUSTSEC advisory ID. It should be RUSTSEC-2024-0049, not RUSTSEC-2026-0049. With the incorrect ID, cargo deny won't ignore the correct advisory, likely causing the security check to fail.
For easier maintenance, please also add a link to the upstream issue tracking this, which appears to be awslabs/aws-sdk-rust#1211. This will help in tracking when this ignore can be removed.
| { id = "RUSTSEC-2026-0049", reason = "rustls-webpki 0.101.7 via rustls 0.21 in aws-smithy-http-client - no safe upgrade available" }, | |
| { id = "RUSTSEC-2024-0049", reason = "rustls-webpki 0.101.7 via rustls 0.21 in aws-smithy-http-client - no safe upgrade available, see https://github.com/awslabs/aws-sdk-rust/issues/1211" }, |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.9 x -- echo |
24.5 ± 0.6 | 23.4 | 30.1 | 1.01 ± 0.05 |
mise x -- echo |
24.2 ± 1.0 | 23.3 | 35.5 | 1.00 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.9 env |
23.8 ± 0.8 | 22.8 | 30.2 | 1.00 |
mise env |
24.1 ± 0.7 | 22.8 | 26.9 | 1.01 ± 0.05 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.9 hook-env |
24.2 ± 0.4 | 23.5 | 26.9 | 1.00 |
mise hook-env |
24.7 ± 0.6 | 23.4 | 27.0 | 1.02 ± 0.03 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.3.9 ls |
23.5 ± 1.5 | 22.4 | 45.4 | 1.01 ± 0.07 |
mise ls |
23.3 ± 0.6 | 22.7 | 32.8 | 1.00 |
xtasks/test/perf
| Command | mise-2026.3.9 | mise | Variance |
|---|---|---|---|
| install (cached) | 151ms | 151ms | +0% |
| ls (cached) | 83ms | 83ms | +0% |
| bin-paths (cached) | 87ms | 86ms | +1% |
| task-ls (cached) | 819ms | 828ms | -1% |
Summary
aws-lc-rs1.15.4 → 1.16.2 andaws-lc-sys0.37.0 → 0.39.0 to fix RUSTSEC-2026-0044 through 0048rustls-webpki0.103.9 → 0.103.10 to fix RUSTSEC-2026-0049rustls-webpki0.101.7 (pinned byrustls0.21 inaws-smithy-http-client, no safe upgrade available upstream)Test plan
cargo deny checkpasses🤖 Generated with Claude Code
Note
Medium Risk
Updates core TLS/crypto dependencies (
aws-lc-*,rustls-webpki) and adjusts advisory handling, which can subtly affect certificate validation and TLS behavior even though changes are dependency-only.Overview
Updates the Rust dependency lockfile to pull in patched security-related crates, notably
aws-lc-rs/aws-lc-sysandrustls-webpki(plus associated transitive version shifts likewindows-sys,windows-registry, andbase64).Adds a
cargo-denyadvisory ignore entry forRUSTSEC-2026-0049to acknowledge an un-upgradablerustls-webpki 0.101.7pulled viarustls 0.21/aws-smithy-http-client.Written by Cursor Bugbot for commit ef8bbfd. This will update automatically on new commits. Configure here.