Skip to content

fix(task): correctly resolve task name for _default files with extensions #8646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 4 commits into from
Mar 19, 2026
Merged

fix(task): correctly resolve task name for _default files with extensions #8646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96c6a2b
fix(task): correctly resolve task name for _default files with extens…
youta1119 Mar 18, 2026
2e1d0b5
[autofix.ci] apply automated fixes
autofix-ci[bot] Mar 18, 2026
5b01b84
refactor(task): rename prefix to parent to avoid shadowing
youta1119 Mar 18, 2026
cf63403
[autofix.ci] apply automated fixes
autofix-ci[bot] Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion e2e/tasks/test_task_default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@

assert "mise tasks add --file foo:bar:baz -- echo baz"
assert "mise tasks add --file foo:bar -- echo bar"
assert "mise tasks add --file foo:_default.sh -- echo foo"
ls -lR .

assert "mise tasks" "foo:bar
assert "mise tasks" "foo
foo:bar
foo:bar:baz"
assert "mise tasks run foo:bar:baz" "baz"
assert "mise tasks run foo:bar" "bar"

assert "mise tasks run foo" "foo"
14 changes: 10 additions & 4 deletions src/task/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,11 +1112,12 @@ fn name_from_path(prefix: impl AsRef<Path>, path: impl AsRef<Path>) -> Result<St
.map(ffi::OsStr::to_string_lossy)
.map(|s| s.replace(':', "_"))
.join(":");
if let Some(name) = name.strip_suffix(":_default") {
Ok(name.to_string())
} else {
Ok(name)
if let Some((parent, last)) = name.rsplit_once(':')
&& strip_extension(last) == "_default"
{
return Ok(parent.to_string());
}
Ok(name)
}

/// Extract monorepo path from a task name
Expand Down Expand Up @@ -1634,6 +1635,11 @@ mod tests {
(("/.mise/tasks", "/.mise/tasks/a/b/c"), "a:b:c"),
(("/.mise/tasks", "/.mise/tasks/a:b"), "a_b"),
(("/.mise/tasks", "/.mise/tasks/a:b/c"), "a_b:c"),
(("/.mise/tasks", "/.mise/tasks/a/_default"), "a"),
(("/.mise/tasks", "/.mise/tasks/a/_default.sh"), "a"),
(("/.mise/tasks", "/.mise/tasks/a/_default.js"), "a"),
(("/.mise/tasks", "/.mise/tasks/a/b/_default"), "a:b"),
(("/.mise/tasks", "/.mise/tasks/a/b/_default.sh"), "a:b"),
];

for ((root, path), expected) in test_cases {
Expand Down
Loading