feat(aqua): add JAR file support and ktfmt registry entry

[Jarvvski]

Summary

• Add generic JAR file support to the aqua backend — when a raw format asset ends in .jar, mise now creates a shell wrapper that invokes java -jar instead of copying the JAR directly as the binary
• Add ktfmt to the registry (aqua:facebook/ktfmt) as the first tool to use this

An example of the generated wrapper:

  #!/bin/sh
  if [ -n "$JAVA_HOME" ]; then
    exec "$JAVA_HOME/bin/java" -jar
  "/path/to/installs/ktfmt/0.53/ktfmt.jar" "$@"
  else
    exec java -jar "/path/to/installs/ktfmt/0.53/ktfmt.jar" "$@"
  fi

Context

ktfmt is distributed as a fat JAR (ktfmt-<version>-with-dependencies.jar). JAR files aren't directly executable, so the aqua backend now detects .jar assets and generates a #!/bin/sh wrapper that respects $JAVA_HOME if set.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates ktfmt, a Kotlin code formatting tool, into the system's registry. This enhancement streamlines the process of maintaining consistent Kotlin code style, leveraging recent advancements in aqua's jar support and ktfmt's availability in the aqua-registry.

Highlights

• New Tool Integration: The ktfmt Kotlin code formatter has been added to the registry, enabling standardized formatting for Kotlin projects.
• Leveraging Existing Infrastructure: This integration utilizes the recently added jar support within aqua and ktfmt's existing entry in the aqua-registry.

Changelog

• registry/ktfmt.toml
  • Added the configuration file for ktfmt, defining its backend, Java dependency, description, and verification tests.

Activity

• The author, Jarvvski, created this pull request to add ktfmt to the registry.
• This PR follows the successful implementation of jar support in aquaproj/aqua#4625.
• It also builds on ktfmt being added to the aquaproj/aqua-registry#50235.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for the ktfmt Kotlin formatter by adding its configuration to the registry. The dependency on java is correctly specified. However, the test configuration for verifying the installation is incorrect and will likely fail. I've provided a suggestion to fix the expected output of the version check command.

[gemini-code-assist]

The test configuration appears to be incorrect. The test array is typically in the format ["<command>", "<expected_output>"]. The ktfmt --version command outputs only the version number (e.g., 0.46), not a string like ktfmt version 0.46. As a result, this test is likely to fail.

To fix this, the expected output should be the version placeholder to match the actual command output.

Suggested change

	test = ["ktfmt --version", "ktfmt version {{version}}"]
	test = ["ktfmt --version", "{{version}}"]

[Jarvvski]

This isn't correct:

ktfmt --version
ktfmt version 0.61

[greptile-apps]

Greptile Summary

This PR extends the aqua backend's format == "raw" installation path to detect .jar assets, copies the JAR alongside the install directory, and generates a #!/bin/sh wrapper that invokes java -jar <absolute-jar-path>. It also adds ktfmt as the first consumer of this new path, with correct depends = ["java"] and the upstream asset template.

Key points:

• The Unix happy path is functionally correct: the wrapper is written to first_bin_path, the make_executable loop correctly marks the wrapper (not the JAR) executable, and the srcs/symlink_bins interaction is sound for single-binary packages.
• The test command in registry/ktfmt.toml (ktfmt --version with expected = "ktfmt version {{version}}") is unverified — the ktfmt README does not document a --version flag, raising the possibility that the test will always fail or produce a false negative on installation checks.
• Three items already flagged in prior review threads remain open: the hardcoded absolute JAR path in the wrapper, the lack of a Windows .cmd wrapper, and first_bin_path.with_extension("jar") silently replacing an existing extension rather than appending .jar.
• No unit tests are added for the new code branch in aqua.rs.

Confidence Score: 2/5

• Not safe to merge as-is — multiple open issues from prior threads remain unaddressed and the new test command is unverified.
• The Unix installation flow is logically sound, but the PR carries three un-addressed issues flagged in earlier review rounds (hardcoded absolute path, no Windows support, incorrect use of with_extension) plus a new concern about the unverified --version test in ktfmt.toml. Any of the prior three issues can cause real user-facing failures (stale path after MISE_DATA_DIR change; broken Windows installs; silent extension clobber for future JAR tools), and the test concern means CI may not catch regressions.
• src/backend/aqua.rs (wrapper generation logic) and registry/ktfmt.toml (unverified test command) need the most attention before merge.

Important Files Changed

Filename	Overview
src/backend/aqua.rs	Adds JAR detection in the format == "raw" branch: copies the JAR to first_bin_path.with_extension("jar") and writes a #!/bin/sh wrapper. Correct on Unix for the happy path; wrapper embeds an absolute JAR path (flagged separately) and has no Windows-compatible counterpart (flagged separately). The make_executable logic and srcs/symlink_bins interaction are handled correctly for the single-binary ktfmt case.
crates/aqua-registry/aqua-registry/pkgs/facebook/ktfmt/registry.yaml	Adds the ktfmt aqua registry entry with format: raw and complete_windows_ext: false. Asset template correctly uses trimV to strip the leading v from the version tag. No bins/files field is needed since the fallback binary name (ktfmt) matches the expected wrapper name.
registry/ktfmt.toml	Adds the mise registry entry for ktfmt with correct depends = ["java"] and aqua:facebook/ktfmt backend. The test command may be unreliable if ktfmt's JAR CLI doesn't expose --version (not documented in the ktfmt README).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[AquaBackend::install called\nformat = raw, filename = *.jar] --> B{filename.ends_with\n.jar ?}
    B -- No --> C[file::copy tarball\nto first_bin_path]
    B -- Yes --> D[Compute jar_path =\nfirst_bin_path.with_extension jar]
    D --> E[file::copy tarball\nto jar_path]
    E --> F[Generate sh wrapper\nwith absolute jar_path\nembedded via formatdoc!]
    F --> G[file::write wrapper\nto first_bin_path]
    G --> H[make_executable = true]
    C --> H
    H --> I[Loop over bin_paths:\nfile::make_executable\nwrapper script]
    I --> J{symlink_bins?}
    J -- Yes --> K[create_symlink_bin_dir:\nsymlink to wrapper in .mise-bins/]
    J -- No --> L[Done]
    K --> L

Loading

_{Last reviewed commit: 9d4455b}

[autofix-ci]

Hi! I'm autofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests.

I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:

1. Allow edits by maintainers for your pull request, and then re-trigger CI (for example by pushing a new commit).
2. Manually fix the issues identified for your pull request (see the GitHub Actions output for details on what I would like to change).

[Jarvvski]

@jdx think we can look at getting this merged?

[risu729]

For context: Aqua recently added support in aquaproj/aqua#4625

I don't use Windows, so not too sure, but I think we shouldn't ignore them?

[risu729]

Also, it might be worth adding an e2e test with a pinned version of ktfmt in e2e/. The registry test will be ignored when flaky (for a week after the new release of the tool if I remember correctly).

[Jarvvski]

For context: Aqua recently added support in aquaproj/aqua#4625

I don't use Windows, so not too sure, but I think we shouldn't ignore them?

I'd suggest supporting windows once others post an issue / chat in discord, instead of holding back the PR

[jdx]

I don't think we should do anything like this for raw aqua types

[Jarvvski]

I don't think we should do anything like this for raw aqua types

Ok, what would you prefer? Or will mise never support tools like this?