Skip to content

feat(task): add interactive field for exclusive terminal access #8491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 11 commits into from
Mar 7, 2026
Merged

feat(task): add interactive field for exclusive terminal access #8491

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d931e01
feat(task): add `interactive` field for exclusive terminal access
jdx Mar 7, 2026
c302cf9
fix(task): address PR feedback for interactive lock
jdx Mar 7, 2026
bc92b0a
fix(task): use block_in_place for blocking execute, add interactive t…
jdx Mar 7, 2026
862908e
refactor(task): extract acquire_runtime_lock helper to deduplicate lo…
jdx Mar 7, 2026
06c455a
fix(task): hoist runtime lock outside script loop for consistent excl…
jdx Mar 7, 2026
a7ba99a
fix(task): acquire runtime lock after confirmation in file-based tasks
jdx Mar 7, 2026
cca97d3
fix(task): acquire runtime lock before confirmation for interactive f…
jdx Mar 7, 2026
07b78f4
fix(task): emit distinct redaction warning for interactive tasks
jdx Mar 7, 2026
3658557
fix(task): acquire lock before confirmation for interactive run-entry…
jdx Mar 7, 2026
f872457
fix(task): pass confirmation lock guard to exec_task_run_entries
jdx Mar 7, 2026
4126daa
fix(task): fix redaction hint for interactive+raw tasks and suppress …
jdx Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions e2e/tasks/test_task_info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ assert_json "mise tasks info lint --json" "$(
"dir": null,
"hide": false,
"raw": false,
"interactive": false,
"sources": [],
"outputs": [],
"shell": null,
Expand Down
6 changes: 6 additions & 0 deletions e2e/tasks/test_task_ls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ assert_json "mise tasks ls --json" "$(
"hide": false,
"global": false,
"raw": false,
"interactive": false,
"sources": [],
"outputs": [],
"shell": null,
Expand Down Expand Up @@ -98,6 +99,7 @@ assert_json "mise tasks ls --json" "$(
"hide": false,
"global": false,
"raw": false,
"interactive": false,
"sources": [],
"outputs": [],
"shell": null,
Expand All @@ -123,6 +125,7 @@ assert_json "mise tasks ls --json" "$(
"hide": false,
"global": false,
"raw": false,
"interactive": false,
"sources": [],
"outputs": [],
"shell": null,
Expand All @@ -148,6 +151,7 @@ assert_json "mise tasks ls --json" "$(
"hide": false,
"global": false,
"raw": false,
"interactive": false,
"sources": [],
"outputs": [],
"shell": null,
Expand Down Expand Up @@ -175,6 +179,7 @@ assert_json "mise tasks ls --json" "$(
"hide": false,
"global": false,
"raw": false,
"interactive": false,
"sources": [],
"outputs": [],
"shell": null,
Expand Down Expand Up @@ -205,6 +210,7 @@ assert_json "mise tasks ls --json" "$(
"hide": false,
"global": false,
"raw": false,
"interactive": false,
"sources": [],
"outputs": [],
"shell": null,
Expand Down
10 changes: 10 additions & 0 deletions schema/mise-task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,11 @@
}
]
},
"interactive": {
"default": false,
"description": "mark task as interactive, acquiring exclusive terminal access while allowing other non-interactive tasks to run in parallel",
"type": "boolean"
},
"raw": {
"default": false,
"description": "directly connect task to stdin/stdout/stderr",
Expand Down Expand Up @@ -885,6 +890,11 @@
}
]
},
"interactive": {
"default": false,
"description": "mark task as interactive, acquiring exclusive terminal access while allowing other non-interactive tasks to run in parallel",
"type": "boolean"
},
"raw": {
"default": false,
"description": "directly connect task to stdin/stdout/stderr",
Expand Down
15 changes: 15 additions & 0 deletions schema/mise.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1841,6 +1841,11 @@
}
]
},
"interactive": {
"default": false,
"description": "mark task as interactive, acquiring exclusive terminal access while allowing other non-interactive tasks to run in parallel",
"type": "boolean"
},
"raw": {
"default": false,
"description": "directly connect task to stdin/stdout/stderr",
Expand Down Expand Up @@ -2434,6 +2439,11 @@
}
]
},
"interactive": {
"default": false,
"description": "mark task as interactive, acquiring exclusive terminal access while allowing other non-interactive tasks to run in parallel",
"type": "boolean"
},
"raw": {
"default": false,
"description": "directly connect task to stdin/stdout/stderr",
Expand Down Expand Up @@ -2679,6 +2689,11 @@
}
]
},
"interactive": {
"default": false,
"description": "mark task as interactive, acquiring exclusive terminal access while allowing other non-interactive tasks to run in parallel",
"type": "boolean"
},
"raw": {
"default": false,
"description": "directly connect task to stdin/stdout/stderr",
Expand Down
1 change: 1 addition & 0 deletions src/cli/mcp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ impl ServerHandler for MiseServer {
"dir": task.dir.clone(),
"hide": task.hide,
"raw": task.raw,
"interactive": task.interactive,
"sources": task.sources.clone(),
"outputs": task.outputs.clone(),
"shell": task.shell.clone(),
Expand Down
1 change: 1 addition & 0 deletions src/cli/tasks/info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ impl TasksInfo {
"dir": task.dir,
"hide": task.hide,
"raw": task.raw,
"interactive": task.interactive,
Comment thread
cursor[bot] marked this conversation as resolved.
"sources": task.sources,
"outputs": task.outputs,
"shell": task.shell,
Expand Down
1 change: 1 addition & 0 deletions src/cli/tasks/ls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ impl TasksLs {
"hide": task.hide,
"global": task.global,
"raw": task.raw,
"interactive": task.interactive,
"sources": task.sources,
"outputs": task.outputs,
"shell": task.shell,
Expand Down
6 changes: 6 additions & 0 deletions src/task/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,8 @@ pub struct Task {
#[serde(default)]
pub raw: bool,
#[serde(default)]
pub interactive: bool,
#[serde(default)]
pub sources: Vec<String>,
#[serde(default)]
pub outputs: TaskOutputs,
Expand Down Expand Up @@ -380,6 +382,7 @@ impl Task {
task.dir = p.parse_str("dir");
task.hide = !file::is_executable(path) || p.parse_bool("hide").unwrap_or_default();
task.raw = p.parse_bool("raw").unwrap_or_default();
task.interactive = p.parse_bool("interactive").unwrap_or_default();
task.sources = p.parse_array("sources").unwrap_or_default();
task.outputs = p.get_raw("outputs").map(|to| to.into()).unwrap_or_default();
task.file = Some(path.to_path_buf());
Expand Down Expand Up @@ -1245,6 +1248,7 @@ impl Default for Task {
hide: false,
global: false,
raw: false,
interactive: false,
sources: vec![],
outputs: Default::default(),
raw_outputs: Default::default(),
Expand Down Expand Up @@ -2269,6 +2273,7 @@ echo "hello world"
#MISE dir="/some/dir"
#MISE hide=true
#MISE raw=true
#MISE interactive=true
#MISE sources=["src1.txt", "src2.txt"]
#MISE outputs=["out1.txt"]
#MISE shell="bash -c"
Expand All @@ -2294,6 +2299,7 @@ echo "test"
assert_eq!(task.dir, Some("/some/dir".to_string()));
assert_eq!(task.hide, true);
assert_eq!(task.raw, true);
assert_eq!(task.interactive, true);
assert_eq!(task.sources, vec!["src1.txt", "src2.txt"]);
assert_eq!(task.shell, Some("bash -c".to_string()));
assert_eq!(task.quiet, true);
Expand Down
15 changes: 13 additions & 2 deletions src/task/task_executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,17 @@ use std::iter::once;
use std::ops::Deref;
use std::path::{Path, PathBuf};
use std::process::Stdio;
use std::sync::{Arc, Mutex as StdMutex};
use std::sync::{Arc, LazyLock, Mutex as StdMutex};
use std::time::{Duration, SystemTime};
use tokio::sync::Mutex;
use tokio::sync::RwLock;
use tokio::sync::{mpsc, oneshot};
use xx::file;

/// Global lock for interactive task exclusivity.
/// Interactive tasks acquire a write lock (exclusive), non-interactive tasks acquire a read lock (shared).
static TASK_RUNTIME_LOCK: LazyLock<RwLock<()>> = LazyLock::new(|| RwLock::new(()));

/// Configuration for TaskExecutor
pub struct TaskExecutorConfig {
pub force: bool,
Expand Down Expand Up @@ -793,7 +798,13 @@ impl TaskExecutor {
if let Some(timeout) = effective_timeout {
cmd = cmd.with_timeout(timeout);
}
cmd.execute()?;
Comment thread
cursor[bot] marked this conversation as resolved.
if task.interactive {
let _guard = TASK_RUNTIME_LOCK.write().await;
cmd.execute()?;
} else {
let _guard = TASK_RUNTIME_LOCK.read().await;
cmd.execute()?;
}
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
trace!("{prefix} exited successfully");
Ok(())
}
Expand Down
2 changes: 1 addition & 1 deletion src/task/task_output_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ impl OutputHandler {
}

pub fn raw(&self, task: Option<&Task>) -> bool {
self.raw || Settings::get().raw || task.is_some_and(|t| t.raw)
self.raw || Settings::get().raw || task.is_some_and(|t| t.raw || t.interactive)
}
Comment thread
greptile-apps[bot] marked this conversation as resolved.

pub fn jobs(&self) -> usize {
Expand Down
Loading