Skip to content

registry: disable sd version test #8489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
Mar 7, 2026
Merged

registry: disable sd version test #8489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion registry/sd.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
backends = ["aqua:chmln/sd", "cargo:sd"]
description = "Intuitive find & replace CLI (sed alternative)"
test = { cmd = "sd --version", expected = "sd {{version}}" }
# test = { cmd = "sd --version", expected = "sd {{version}}" } # upstream bug: v1.1.0 reports "sd 1.0.0"

@gemini-code-assist gemini-code-assist Bot Mar 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Disabling a test, even temporarily, reduces confidence in the system's correctness. While the upstream bug necessitates this workaround, it's crucial to have a clear plan for re-enabling or adapting this test. Leaving it commented out indefinitely could lead to regressions or missed opportunities to validate the sd tool's version behavior. Please consider adding a specific reference to the upstream issue and a clear action item for when it should be re-enabled or modified.

Suggested change
# test = { cmd = "sd --version", expected = "sd {{version}}" } # upstream bug: v1.1.0 reports "sd 1.0.0"
# test = { cmd = "sd --version", expected = "sd {{version}}" } # TODO(upstream_issue_link): Re-enable/adapt test when upstream bug (v1.1.0 reports v1.0.0) is fixed.

Loading