Skip to content

docs: remove duplicated docs for npm.package_manager#8414

Merged
jdx merged 1 commit into
jdx:mainfrom
risu729:duplicate-npm-pm
Mar 2, 2026
Merged

docs: remove duplicated docs for npm.package_manager#8414
jdx merged 1 commit into
jdx:mainfrom
risu729:duplicate-npm-pm

Conversation

@risu729

@risu729 risu729 commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the configuration documentation by eliminating redundant information. By removing duplicated details about package manager options, it enhances the clarity and conciseness of the settings.toml file, making it easier to read and maintain without altering any functional behavior.

Highlights

  • Documentation Cleanup: Removed redundant documentation for the npm.package_manager setting in settings.toml. The list of available package managers (npm, bun, pnpm) was duplicated in the docs string and the enum field, so the docs string was simplified.
Changelog
  • settings.toml
    • Removed redundant package manager options from the docs string, as this information is already present in the enum field.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes redundant documentation for the npm.package_manager setting in settings.toml. The list of possible values was hardcoded in the docs field, while also being defined in the enum field. Removing the hardcoded list is a good cleanup that improves maintainability by making the enum field the single source of truth. The change is correct and I have no further suggestions.

@jdx jdx enabled auto-merge (squash) March 2, 2026 04:30
@greptile-apps

greptile-apps Bot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes redundant documentation from the npm.package_manager setting that duplicated information already captured in the enum and default fields. The change is consistent with documentation patterns used elsewhere in the file, where enum values are not repeated in the docs field unless they require additional explanation.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change only removes redundant documentation text without affecting any functionality or behavior. The information being removed is already available through the structured enum field, making this a clean documentation improvement.
  • No files require special attention

Important Files Changed

Filename Overview
settings.toml Removed redundant documentation that duplicated enum values already defined in the schema

Last reviewed commit: 16e82f9

@jdx jdx merged commit 90d88e2 into jdx:main Mar 2, 2026
35 checks passed
@risu729 risu729 deleted the duplicate-npm-pm branch March 2, 2026 09:04
jdx pushed a commit that referenced this pull request Mar 2, 2026
### 🚀 Features

- **(hooks)** add task references to hooks and watch_files by @jdx in
[#8400](#8400)
- **(prepare)** add git-submodule built-in provider by @jdx in
[#8407](#8407)
- **(prepare)** add human-readable stale reasons to prepare output by
@jdx in [#8408](#8408)
- **(prepare)** add dependency ordering to prepare steps by @jdx in
[#8401](#8401)
- **(prepare)** add --explain flag for provider diagnostics by @jdx in
[#8409](#8409)
- **(prepare)** add per-provider timeout support by @jdx in
[#8405](#8405)
- **(prepare)** add blake3 content-hash freshness checking by @jdx in
[#8404](#8404)
- **(tasks)** monorepo vars and per-task vars by @halms in
[#8248](#8248)

### 🐛 Bug Fixes

- **(aqua)** restore bin_paths disk cache with fresh_file invalidation
by @jdx in [#8398](#8398)
- **(idiomatic)** use generic parser for idiomatic files by @risu729 in
[#8171](#8171)
- **(install)** apply precompiled options to all platforms in lockfile
by @jdx in [#8396](#8396)
- **(install)** normalize "v" prefix when matching lockfile versions by
@jdx in [#8413](#8413)
- **(prepare)** improve git submodule parser and fix check_staleness
error handling by @jdx in [#8412](#8412)
- **(python)** respect precompiled settings in lock file generation by
@jdx in [#8399](#8399)
- **(python)** clarify uv_venv_auto docs + prevent uv shim recursion in
venv creation by @halms in
[#8402](#8402)
- **(task)** remove deprecated `# mise` task header syntax by @jdx in
[#8403](#8403)
- **(vfox)** avoid eager metadata loading during config file detection
by @jdx in [#8397](#8397)
- clarify GitHub attestations to be artifact ones by @scop in
[#8394](#8394)
- ignore comments in idiomatic version files by @iloveitaly in
[#7682](#7682)

### 🚜 Refactor

- unify archive detection by @risu729 in
[#8137](#8137)

### 📚 Documentation

- remove duplicated docs for npm.package_manager by @risu729 in
[#8414](#8414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants