-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(install): improve error when registry tool has no supported backends #8388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fa4d4d6
fix(install): improve error when registry tool has no supported backends
jdx 1aef546
fix(install): use "current configuration" instead of "this platform" …
jdx ec3383f
[autofix.ci] apply automated fixes
autofix-ci[bot] 094f1a5
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -175,10 +175,22 @@ impl BackendArg { | |||||||||||||||||||||
| bail!("{plugin_name} is not a valid plugin name"); | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } else { | ||||||||||||||||||||||
| // Check if the tool is in the registry but has no available backends | ||||||||||||||||||||||
| if let Some(rt) = REGISTRY.get(self.short.as_str()) { | ||||||||||||||||||||||
| if rt.backends().is_empty() && !rt.backends.is_empty() { | ||||||||||||||||||||||
| let all_backends: Vec<&str> = rt.backends.iter().map(|rb| rb.full).collect(); | ||||||||||||||||||||||
| bail!( | ||||||||||||||||||||||
| "{self} is in the mise tool registry but none of its backends ({}) are supported on this platform", | ||||||||||||||||||||||
| all_backends.join(", ") | ||||||||||||||||||||||
| ); | ||||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To improve performance and code clarity, you can use
Suggested change
|
||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| let registry_shorts: Vec<&str> = REGISTRY.keys().copied().collect(); | ||||||||||||||||||||||
| let mut suggestions: Vec<String> = | ||||||||||||||||||||||
| xx::suggest::similar_n_with_threshold(&self.short, ®istry_shorts, 3, 0.8) | ||||||||||||||||||||||
| .into_iter() | ||||||||||||||||||||||
| .filter(|s| *s != self.short) | ||||||||||||||||||||||
| .map(|s| s.to_string()) | ||||||||||||||||||||||
| .collect(); | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.