Skip to content

fix(install): clear aqua bin_paths cache after install to prevent stale PATH #8374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
Feb 27, 2026
Merged

fix(install): clear aqua bin_paths cache after install to prevent stale PATH #8374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/backend/aqua.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,15 @@ impl Backend for AquaBackend {
}
self.install(ctx, &tv, &pkg, &v, &filename)?;

// Clear any cached bin paths so they are recomputed now that installation is complete.
// Without this, a stale cache (e.g. computed before extraction finished) could persist
// and cause the tool's PATH entry to be missing.
self.bin_path_caches.remove(&tv.version);
let cache_path = tv.cache_path().join("bin_paths.msgpack.z");
if cache_path.exists() {
let _ = file::remove_file(&cache_path);
}
Comment on lines +469 to +471

@gemini-code-assist gemini-code-assist Bot Feb 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of directly removing the cache file, consider using a more robust approach that handles potential errors during file removal. For instance, logging the error if the file removal fails can aid in debugging. Additionally, consider retrying the removal a few times with a short delay in case of transient issues.

        self.bin_path_caches.remove(&tv.version);
        let cache_path = tv.cache_path().join(


Ok(tv)
}

Expand Down
Loading