Skip to content

fix(config): respect --yes flag for config trust prompts #8288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 3 commits into from
Feb 21, 2026
Merged

fix(config): respect --yes flag for config trust prompts #8288

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5396fe
fix(config): respect --yes flag for config trust prompts
jdx Feb 21, 2026
d8784e9
fix(test): override MISE_YES in monorepo trust test
jdx Feb 21, 2026
048ab8c
fix(test): override MISE_YES in untrusted config error test
jdx Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/config/config_file/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,12 @@ pub fn trust_check(path: &Path) -> eyre::Result<()> {
return Ok(());
}
if cmd != "hook-env" && !is_ignored(&config_root) && !is_ignored(path) {
let ans = prompt::confirm_with_all(format!(
"{} config files in {} are not trusted. Trust them?",
style::eyellow("mise"),
style::epath(&config_root)
))?;
let ans = (settings::is_loaded() && Settings::get().yes)
|| prompt::confirm_with_all(format!(
"{} config files in {} are not trusted. Trust them?",
style::eyellow("mise"),
style::epath(&config_root)
))?;
Comment on lines +303 to +308

@gemini-code-assist gemini-code-assist Bot Feb 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This implementation is a bit brittle. It relies on settings being loaded before this function is called. If trust_check is ever called in a context where settings haven't been loaded, settings::is_loaded() will be false, and the user will be prompted even if they passed --yes or MISE_YES=1.

A more robust approach would be to attempt to load the settings here. This ensures the --yes flag is always respected, regardless of the call context.

Using try_get() and mapping the result is a safe way to do this without panicking if settings fail to load, falling back to prompting in that case.

Suggested change
let ans = (settings::is_loaded() && Settings::get().yes)
|| prompt::confirm_with_all(format!(
"{} config files in {} are not trusted. Trust them?",
style::eyellow("mise"),
style::epath(&config_root)
))?;
let ans = settings::Settings::try_get().map(|s| s.yes).unwrap_or(false)
|| prompt::confirm_with_all(format!(
"{} config files in {} are not trusted. Trust them?",
style::eyellow("mise"),
style::epath(&config_root)
))?;

if ans {
trust(&config_root)?;
return Ok(());
Expand Down
Loading