Skip to content

fix(hook-env): skip remote version fetching for uninstalled tools in prefer-offline mode #7976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 10 commits into from
Feb 3, 2026
Merged

fix(hook-env): skip remote version fetching for uninstalled tools in prefer-offline mode #7976

Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e47dcfe
feat(vfox): add LuaCATS type definitions for plugin IDE support
jdx Feb 2, 2026
8547b22
feat: add "Did you mean?" suggestions for unknown tools
jdx Feb 2, 2026
3096a1d
feat(install): warn when installing tools not in any config file
jdx Feb 2, 2026
c184615
chore: loosen xx version requirement to "2"
jdx Feb 2, 2026
89c12f1
Merge remote-tracking branch 'origin/main' into feat/did-you-mean-sug…
jdx Feb 2, 2026
79a6a89
[autofix.ci] apply automated fixes
autofix-ci[bot] Feb 2, 2026
775045a
fix: address PR review feedback
jdx Feb 2, 2026
c3d43cf
fix(hook-env): skip remote version fetching for uninstalled tools in …
jdx Feb 3, 2026
d6e541f
Merge remote-tracking branch 'origin/main' into fix/hook-env-skip-rem…
jdx Feb 3, 2026
33626be
fix: address PR review feedback
jdx Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/toolset/tool_version.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ use std::{collections::BTreeMap, sync::Arc};
use crate::backend::ABackend;
use crate::cli::args::BackendArg;
use crate::config::Config;
use crate::env;
#[cfg(windows)]
use crate::file;
use crate::hash::hash_to_str;
Expand Down Expand Up @@ -247,6 +248,9 @@ impl ToolVersion {
return build(v.clone());
}
}
if env::PREFER_OFFLINE.load(std::sync::atomic::Ordering::Relaxed) {
return build(v);
}
// First try with date filter (common case)
let matches = backend
.list_versions_matching_with_opts(config, &v, opts.before_date)
Expand Down
Loading