-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(task): support env vars in task dependencies #7724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
12a3f82
feat(task): support env vars in task dependencies
jdx cc0d4bf
docs(task): document env vars in task dependencies
jdx 974f8e7
fix(task): add validation and improve deduplication for dep env vars
jdx 41f14d3
fix(task): ensure consistent Ord/Hash/PartialEq with sorted env vars
jdx f5a17e5
fix(task): separate inherited env from task's own env for deduplication
jdx 7d5a07e
fix(task): use separate methods for dependency vs inherited env
jdx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # Test passing env vars to task dependencies | ||
|
|
||
| # Test shell-style env var syntax: "FOO=bar mytask" | ||
| cat <<EOF >mise.toml | ||
| [tasks.show-env] | ||
| run = 'echo "FOO=\$FOO BAZ=\$BAZ"' | ||
|
|
||
| [tasks.with-env-string] | ||
| depends = ["FOO=hello show-env"] | ||
| run = 'echo done' | ||
|
|
||
| [tasks.with-multiple-env] | ||
| depends = ["FOO=hello BAZ=world show-env"] | ||
| run = 'echo done' | ||
| EOF | ||
|
|
||
| assert_contains "mise run with-env-string" "FOO=hello" | ||
| assert_contains "mise run with-multiple-env" "FOO=hello BAZ=world" | ||
|
|
||
| # Test structured object syntax: { task = "mytask", env = { FOO = "bar" } } | ||
| cat <<EOF >mise.toml | ||
| [tasks.show-env] | ||
| run = 'echo "FOO=\$FOO BAZ=\$BAZ"' | ||
|
|
||
| [tasks.with-env-object] | ||
| depends = [{ task = "show-env", env = { FOO = "hello", BAZ = "world" } }] | ||
| run = 'echo done' | ||
|
|
||
| [tasks.with-env-and-args] | ||
| depends = [{ task = "echo-args", env = { FOO = "test" }, args = ["arg1", "arg2"] }] | ||
| run = 'echo done' | ||
|
|
||
| [tasks.echo-args] | ||
| run = 'echo "FOO=\$FOO" && echo' | ||
| EOF | ||
|
|
||
| assert_contains "mise run with-env-object" "FOO=hello BAZ=world" | ||
| assert_contains "mise run with-env-and-args" "FOO=test" | ||
| # Args are appended to the command line, verify they appear in output | ||
| assert_contains "mise run with-env-and-args" "arg1 arg2" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test verifies that
FOO=testappears in output but doesn't validate that argsarg1andarg2are actually passed to theecho-argstask. The task's run command only echoes the FOO variable and doesn't incorporate the args, making line 42's assertion about args appearing in output unlikely to succeed as intended.