Skip to content

fix(python): sort CPython versions at end of ls-remote output #7721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
Jan 17, 2026
Merged

fix(python): sort CPython versions at end of ls-remote output #7721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions src/plugins/core/python.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,11 @@ pub fn python_path(tv: &ToolVersion) -> PathBuf {
/// - Old format: `miniconda3-{conda_version}` (e.g., `miniconda3-3.16.0`, `miniconda3-4.7.12`)
/// - New format: `miniconda3-{python_version}-{conda_version}` (e.g., `miniconda3-3.7-4.8.2`)
///
/// Returns a tuple for sorting: (is_miniconda, prefix_order, is_not_latest, conda_version, python_version)
/// Returns a tuple for sorting: (distro_priority, prefix_order, is_not_latest, conda_version, python_version)
/// distro_priority: 0 = other distros, 1 = miniconda, 2 = CPython (bare version numbers)
fn python_version_sort_key(
version: &str,
) -> (bool, u8, bool, Option<Versioning>, Option<Versioning>) {
) -> (u8, u8, bool, Option<Versioning>, Option<Versioning>) {
// Check if this is a miniconda version and get prefix order
let (prefix_order, version_part) = if let Some(v) = version.strip_prefix("miniconda3-") {
(2u8, v)
Expand All @@ -57,21 +58,14 @@ fn python_version_sort_key(
} else if let Some(v) = version.strip_prefix("miniconda-") {
(0u8, v)
} else {
// Not miniconda - put non-digit-starting first, then digit-starting
// Use is_miniconda=false to separate from miniconda versions
// Not miniconda - put other distros first (0), CPython (digit-starting) last (2)
let starts_with_digit = regex!(r"^\d").is_match(version);
return (
false,
if starts_with_digit { 1 } else { 0 },
false,
None,
None,
);
return (if starts_with_digit { 2 } else { 0 }, 0, false, None, None);
};

// Handle "latest" specially - put first in each miniconda group
if version_part == "latest" {
return (true, prefix_order, false, None, None);
return (1, prefix_order, false, None, None);
}

// Parse miniconda version: old format vs new format
Expand All @@ -87,7 +81,7 @@ fn python_version_sort_key(
(Versioning::new(version_part), None)
};

(true, prefix_order, true, conda_version, python_version)
(1, prefix_order, true, conda_version, python_version)
}

impl PythonPlugin {
Expand Down
Loading