-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test(registry): add final ci job as merge gate #7390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -121,3 +121,28 @@ jobs: | |||||
| echo "failed_tools=$failed_tools" >> "$GITHUB_OUTPUT" | ||||||
| - if: steps.test-tools.outputs.failed_tools != '' | ||||||
| run: mise test-tool ${{ steps.test-tools.outputs.failed_tools }} | ||||||
|
|
||||||
| ci: | ||||||
| runs-on: ubuntu-latest | ||||||
| timeout-minutes: 1 | ||||||
| needs: | ||||||
| - build | ||||||
| - list-changed-tools | ||||||
| - test-tool | ||||||
| if: always() | ||||||
| steps: | ||||||
| - name: Check CI job results | ||||||
| run: | | ||||||
| if [ "${{ needs.build.result }}" != "success" ]; then | ||||||
| echo "build failed or was skipped" | ||||||
| exit 1 | ||||||
| fi | ||||||
| if [ "${{ needs.list-changed-tools.result }}" != "success" ] && [ "${{ needs.list-changed-tools.result }}" != "skipped" ]; then | ||||||
| echo "list-changed-tools failed" | ||||||
| exit 1 | ||||||
| fi | ||||||
| if [ "${{ needs.test-tool.result }}" != "success" ]; then | ||||||
| echo "test-tool failed or was skipped" | ||||||
|
||||||
| echo "test-tool failed or was skipped" | |
| echo "test-tool failed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message indicates 'or was skipped', but the condition only checks for non-success states. If the build job is actually skipped, this message would be misleading since skipped jobs should potentially be treated differently than failed ones. Consider either checking explicitly for 'skipped' status or removing the 'or was skipped' text from the error message.