-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
registry: switch glab to native gitlab backend #7364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -1885,11 +1885,11 @@ description = "From git log to SemVer in no time" | |||||
|
|
||||||
| [tools.glab] | ||||||
| backends = [ | ||||||
| { full = "ubi:gitlab-org/cli[provider=gitlab,exe=glab]", platforms = [ | ||||||
| { full = "gitlab:gitlab-org/cli[exe=glab]", platforms = [ | ||||||
| "linux", | ||||||
| "macos", | ||||||
| ] }, | ||||||
| { full = 'ubi:gitlab-org/cli[provider=gitlab,exe=glab,matching_regex=^glab\.exe$]', platforms = [ | ||||||
| { full = "gitlab:gitlab-org/cli[exe=glab]", platforms = [ | ||||||
|
||||||
| { full = "gitlab:gitlab-org/cli[exe=glab]", platforms = [ | |
| { full = "gitlab:gitlab-org/cli[exe=glab.exe]", platforms = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Unsupported
exeoption used with gitlab backendThe
exe=glaboption is only supported by theubibackend (insrc/backend/ubi.rs), not by thegitlabbackend which usesUnifiedGitBackend. Thegitlabbackend does not recognize or use theexeoption, so this configuration will be silently ignored. If the intent is to specify the executable name, thegitlabbackend supportsrename_exefor archives orbinfor single binaries instead. Additionally, the Windows configuration previously usedmatching_regex=^glab\.exe$specifically to fix asset selection issues; removing this and switching to a backend without equivalent functionality may cause Windows installations to pick the wrong asset.Additional Locations (1)
registry.toml#L1891-L1892