Skip to content

alias nodejs -> node and golang -> go#664

Merged
jdx merged 1 commit intomainfrom
plugin-aliases
Jul 9, 2023
Merged

alias nodejs -> node and golang -> go#664
jdx merged 1 commit intomainfrom
plugin-aliases

Conversation

@jdx
Copy link
Owner

@jdx jdx commented Jul 9, 2023

Fixes #560

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch coverage: 78.33% and project coverage change: -0.09 ⚠️

Comparison is base (1d2cded) 88.22% compared to head (4da4cc1) 88.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
- Coverage   88.22%   88.13%   -0.09%     
==========================================
  Files         123      124       +1     
  Lines       10233    10276      +43     
==========================================
+ Hits         9028     9057      +29     
- Misses       1205     1219      +14     
Impacted Files Coverage Δ
src/cli/prune.rs 80.00% <ø> (ø)
src/plugins/core/mod.rs 100.00% <ø> (ø)
src/migrate.rs 50.00% <50.00%> (ø)
src/cli/current.rs 89.33% <66.66%> (+0.29%) ⬆️
src/cli/args/tool.rs 98.21% <100.00%> (+0.06%) ⬆️
src/cli/ls.rs 94.25% <100.00%> (+0.08%) ⬆️
src/cli/plugins/install.rs 92.70% <100.00%> (+0.07%) ⬆️
src/cli/plugins/link.rs 94.44% <100.00%> (+0.15%) ⬆️
src/cli/plugins/uninstall.rs 100.00% <100.00%> (ø)
src/cli/plugins/update.rs 92.30% <100.00%> (+0.20%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdx jdx force-pushed the plugin-aliases branch from 7fe0910 to edea452 Compare July 9, 2023 02:12
@jdx jdx force-pushed the plugin-aliases branch from edea452 to 4da4cc1 Compare July 9, 2023 02:30
@jdx jdx enabled auto-merge (squash) July 9, 2023 02:33
@jdx jdx merged commit fe594d4 into main Jul 9, 2023
@jdx jdx deleted the plugin-aliases branch July 9, 2023 02:44
@maciej-szlosarczyk
Copy link

Hey @jdxcode!

I think this breaks compatibility with asdf. If I have the following .tool-versions file:

python 3.10.2
nodejs 18.14.0

And then when I run rtx local python@3.11.2 it becomes:

python 3.11.2
node 18.14.0

At which point node no longer has a valid version definition in asdf.

@jdx
Copy link
Owner Author

jdx commented Jul 18, 2023

makes sense, I can probably make this a special case and keep the existing names

jdx added a commit that referenced this pull request Jul 18, 2023
jdx added a commit that referenced this pull request Jul 19, 2023
jdx added a commit that referenced this pull request Jul 19, 2023
jdx added a commit that referenced this pull request Jul 19, 2023
jdx pushed a commit that referenced this pull request Apr 9, 2024
Co-authored-by: James Hegedus <jthegedus@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugin aliases (node/nodejs)

2 participants