Skip to content

feat: env propagation for depends#6544

Closed
Its-Just-Nans wants to merge 5 commits intojdx:mainfrom
Its-Just-Nans:env-propagation-depends
Closed

feat: env propagation for depends#6544
Its-Just-Nans wants to merge 5 commits intojdx:mainfrom
Its-Just-Nans:env-propagation-depends

Conversation

@Its-Just-Nans
Copy link
Contributor

Following #6342

Test

./e2e/run_test tasks/test_task_env_propagation_depends

@jdx
Copy link
Owner

jdx commented Oct 5, 2025

I do not think this should be done

@Its-Just-Nans
Copy link
Contributor Author

What's the reason?

@jdx
Copy link
Owner

jdx commented Oct 5, 2025

I just don't think it makes sense that a task would inherit the env vars from a task it depends on

@jdx
Copy link
Owner

jdx commented Oct 5, 2025

even if it did work I'd actually expect the relationship to go the other direction—really I don't think we should do this at all. Happy to hear you make a case for it but from this I don't think it's a good idea.

@jdx jdx closed this Oct 5, 2025
@Its-Just-Nans
Copy link
Contributor Author

Its-Just-Nans commented Oct 5, 2025

It was for a potential case like this

[tasks.build]
run = 'do build $BUILD_TYPE' # custom build command

[tasks.dev]
depends = ["build"]
env = { "BUILD_TYPE" = "dev" }

[tasks.deploy]
depends = ["build"]
env = { "BUILD_TYPE" = "production" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants