chore(ci): prevent release workflow from running on release branch pushes#6490
Merged
chore(ci): prevent release workflow from running on release branch pushes#6490
Conversation
The install header was displaying "mise mise" due to the header prefix already containing "mise" (in purple), then normal_prefix() adding another dimmed "mise" prefix. Changed new_header() to use pad_prefix() directly to only show "mise" once in the purple color. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Only run full release builds on: - Push to v* tags (actual releases) - Pull requests to main (filtered by github.head_ref == 'release' in job conditions) - Manual workflow dispatch This prevents the expensive release builds from running on every commit to the release branch. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
jdx
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the CI release workflow to prevent unnecessary builds while maintaining proper release functionality. The change removes the branches: ["release"] trigger from the push event to avoid expensive release builds on every commit to the release branch, while preserving the existing PR-based workflow and tag-based releases.
- Remove unnecessary release branch push trigger from GitHub workflow
- Update function call to use renamed
pad_prefixfunction
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Remove release branch from push triggers to prevent redundant workflow runs |
| src/ui/progress_report.rs | Update function call from normal_prefix to pad_prefix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.24 x -- echo |
19.7 ± 0.3 | 19.1 | 21.9 | 1.00 |
mise x -- echo |
19.7 ± 0.3 | 19.2 | 21.1 | 1.00 ± 0.02 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.24 env |
19.0 ± 0.3 | 18.5 | 20.5 | 1.00 |
mise env |
19.1 ± 0.4 | 18.6 | 25.4 | 1.01 ± 0.03 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.24 hook-env |
18.9 ± 0.4 | 18.1 | 20.7 | 1.01 ± 0.03 |
mise hook-env |
18.7 ± 0.4 | 18.3 | 23.9 | 1.00 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.24 ls |
16.6 ± 0.3 | 16.2 | 17.6 | 1.00 |
mise ls |
16.7 ± 0.3 | 16.2 | 17.8 | 1.00 ± 0.02 |
xtasks/test/perf
| Command | mise-2025.9.24 | mise | Variance |
|---|---|---|---|
| install (cached) | 165ms | ✅ 102ms | +61% |
| ls (cached) | 63ms | 63ms | +0% |
| bin-paths (cached) | 69ms | 69ms | +0% |
| task-ls (cached) | 471ms | 465ms | +1% |
✅ Performance improvement: install cached is 61%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
branches: ["release"]from push trigger to prevent running expensive release builds on every commit to the release branchgithub.head_ref == 'release'conditions that filter jobsContext
The release workflow was running full release builds on every push to the release branch AND on all PRs to main. With the existing job-level conditions checking
github.head_ref == 'release', we only need the PR trigger to main.Test plan
🤖 Generated with Claude Code
Note
Remove
pushtrigger forbranches: ["release"]in.github/workflows/release.yml, leaving only tag pushes (v*), PRs tomain, and manual runs.Written by Cursor Bugbot for commit 9981796. This will update automatically on new commits. Configure here.