fix(install): remove duplicate 'mise' text in install header#6489
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a UI bug where the install header was displaying "mise mise" instead of just "mise" by replacing the normal_prefix() function call with pad_prefix() in the progress report header creation. The change also introduces a local HTTP test server to replace external dependencies in E2E tests for the tool-stub generation functionality.
- Fixed duplicate "mise" text in install header by using
pad_prefix()instead ofnormal_prefix() - Added local HTTP test server for E2E testing to avoid external network dependencies
- Updated tool-stub E2E tests to use the local test server instead of httpbin.org
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ui/progress_report.rs | Changed header prefix function from normal_prefix() to pad_prefix() to fix duplicate text |
| e2e/helpers/scripts/tool_stub_test_server.py | Added new HTTP test server for E2E testing with mock endpoints |
| e2e/generate/test_generate_tool_stub | Updated E2E tests to use local test server instead of external httpbin.org |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The install header was displaying "mise mise" due to the header prefix already containing "mise" (in purple), then normal_prefix() adding another dimmed "mise" prefix. Changed new_header() to use pad_prefix() directly to only show "mise" once in the purple color. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
d619246 to
716912b
Compare
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.24 x -- echo |
20.1 ± 0.5 | 19.1 | 22.3 | 1.00 |
mise x -- echo |
20.3 ± 0.4 | 19.5 | 22.4 | 1.01 ± 0.03 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.24 env |
19.5 ± 0.5 | 18.6 | 24.5 | 1.00 |
mise env |
19.7 ± 0.4 | 18.8 | 21.5 | 1.01 ± 0.03 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.24 hook-env |
18.9 ± 0.3 | 18.2 | 20.2 | 1.00 |
mise hook-env |
19.3 ± 0.7 | 18.4 | 24.9 | 1.02 ± 0.04 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.24 ls |
16.7 ± 0.2 | 16.2 | 17.7 | 1.00 |
mise ls |
16.9 ± 0.9 | 16.2 | 35.6 | 1.01 ± 0.06 |
xtasks/test/perf
| Command | mise-2025.9.24 | mise | Variance |
|---|---|---|---|
| install (cached) | 165ms | ✅ 104ms | +58% |
| ls (cached) | 63ms | 62ms | +1% |
| bin-paths (cached) | 69ms | 69ms | +0% |
| task-ls (cached) | 462ms | 476ms | -2% |
✅ Performance improvement: install cached is 58%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normal_prefix()was adding another dimmed "mise"new_header()to usepad_prefix()directly to show "mise" only onceTest plan
mise installand verify the header shows "mise" only once in purple color🤖 Generated with Claude Code
Note
Switch
new_headerto usepad_prefixinstead ofnormal_prefixto avoid duplicating "mise" in the header.src/ui/progress_report.rsnew_headerto usepad_prefix(pad, &prefix)instead ofnormal_prefix(pad, &prefix), preventing duplicate "mise" in header prefixes.Written by Cursor Bugbot for commit 716912b. This will update automatically on new commits. Configure here.