Skip to content

fix(install): remove duplicate 'mise' text in install header#6489

Merged
jdx merged 1 commit intomainfrom
fix/duplicate-mise-in-install-header
Sep 30, 2025
Merged

fix(install): remove duplicate 'mise' text in install header#6489
jdx merged 1 commit intomainfrom
fix/duplicate-mise-in-install-header

Conversation

@jdx
Copy link
Owner

@jdx jdx commented Sep 30, 2025

Summary

  • Fixed UI glitch where install header displayed "mise mise" instead of just "mise"
  • The header prefix already contained "mise" in purple color, but normal_prefix() was adding another dimmed "mise"
  • Changed new_header() to use pad_prefix() directly to show "mise" only once

Test plan

  • Run mise install and verify the header shows "mise" only once in purple color

🤖 Generated with Claude Code


Note

Switch new_header to use pad_prefix instead of normal_prefix to avoid duplicating "mise" in the header.

  • UI Progress Header:
    • Update src/ui/progress_report.rs new_header to use pad_prefix(pad, &prefix) instead of normal_prefix(pad, &prefix), preventing duplicate "mise" in header prefixes.

Written by Cursor Bugbot for commit 716912b. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings September 30, 2025 14:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a UI bug where the install header was displaying "mise mise" instead of just "mise" by replacing the normal_prefix() function call with pad_prefix() in the progress report header creation. The change also introduces a local HTTP test server to replace external dependencies in E2E tests for the tool-stub generation functionality.

  • Fixed duplicate "mise" text in install header by using pad_prefix() instead of normal_prefix()
  • Added local HTTP test server for E2E testing to avoid external network dependencies
  • Updated tool-stub E2E tests to use the local test server instead of httpbin.org

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/ui/progress_report.rs Changed header prefix function from normal_prefix() to pad_prefix() to fix duplicate text
e2e/helpers/scripts/tool_stub_test_server.py Added new HTTP test server for E2E testing with mock endpoints
e2e/generate/test_generate_tool_stub Updated E2E tests to use local test server instead of external httpbin.org

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

cursor[bot]

This comment was marked as outdated.

The install header was displaying "mise mise" due to the header prefix
already containing "mise" (in purple), then normal_prefix() adding
another dimmed "mise" prefix. Changed new_header() to use pad_prefix()
directly to only show "mise" once in the purple color.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@jdx jdx force-pushed the fix/duplicate-mise-in-install-header branch from d619246 to 716912b Compare September 30, 2025 14:57
@jdx jdx changed the title fix(ui): remove duplicate 'mise' text in install header fix(install): remove duplicate 'mise' text in install header Sep 30, 2025
@github-actions
Copy link

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.9.24 x -- echo 20.1 ± 0.5 19.1 22.3 1.00
mise x -- echo 20.3 ± 0.4 19.5 22.4 1.01 ± 0.03

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.9.24 env 19.5 ± 0.5 18.6 24.5 1.00
mise env 19.7 ± 0.4 18.8 21.5 1.01 ± 0.03

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.9.24 hook-env 18.9 ± 0.3 18.2 20.2 1.00
mise hook-env 19.3 ± 0.7 18.4 24.9 1.02 ± 0.04

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.9.24 ls 16.7 ± 0.2 16.2 17.7 1.00
mise ls 16.9 ± 0.9 16.2 35.6 1.01 ± 0.06

xtasks/test/perf

Command mise-2025.9.24 mise Variance
install (cached) 165ms ✅ 104ms +58%
ls (cached) 63ms 62ms +1%
bin-paths (cached) 69ms 69ms +0%
task-ls (cached) 462ms 476ms -2%

✅ Performance improvement: install cached is 58%

@jdx jdx merged commit b670738 into main Sep 30, 2025
26 checks passed
@jdx jdx deleted the fix/duplicate-mise-in-install-header branch September 30, 2025 15:23
@jdx jdx mentioned this pull request Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants