Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ tera = "1"
terminal_size = "0.4"
thiserror = "2"
tokio = { version = "1", features = ["full"] }
tokio-retry = "0.3"
toml = { version = "0.8", features = ["parse"] }
toml_edit = { version = "0.22", features = ["parse"] }
ubi = { version = "0.7.3", default-features = false }
Expand Down
5 changes: 5 additions & 0 deletions schema/mise.json
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,11 @@
"description": "Timeout in seconds for all HTTP requests in mise.",
"type": "string"
},
"http_retries": {
"default": 0,
"description": "Number of retries for HTTP requests in mise.",
"type": "number"
},
"idiomatic_version_file": {
"default": true,
"description": "Set to false to disable the idiomatic version files such as .node-version, .ruby-version, etc.",
Expand Down
9 changes: 9 additions & 0 deletions settings.toml
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,15 @@ description = "Timeout in seconds for all HTTP requests in mise."
env = "MISE_HTTP_TIMEOUT"
type = "Duration"

[http_retries]
default = 0
description = "Number of retries for HTTP requests in mise."
docs = """
Uses an exponential backoff strategy. The duration is calculated by taking the base (10ms) to the n-th power.
"""
env = "MISE_HTTP_RETRIES"
type = "Integer"

[idiomatic_version_file]
default = true
deprecated = "This has been replaced with the idiomatic_version_file_enable_tools setting."
Expand Down
48 changes: 34 additions & 14 deletions src/http.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ use regex::Regex;
use reqwest::header::{HeaderMap, HeaderValue};
use reqwest::{ClientBuilder, IntoUrl, Method, Response};
use std::sync::LazyLock as Lazy;
use tokio_retry::Retry;
use tokio_retry::strategy::{ExponentialBackoff, jitter};
use url::Url;

use crate::cli::version;
Expand Down Expand Up @@ -201,11 +203,12 @@ impl Client {
) -> Result<()> {
let url = url.into_url()?;
debug!("GET Downloading {} to {}", &url, display_path(path));

let mut resp = self.get_async_with_headers(url, headers).await?;
let mut resp = self.get_async_with_headers(url.clone(), headers).await?;
if let Some(length) = resp.content_length() {
if let Some(pr) = pr {
// Reset progress on each attempt
pr.set_length(length);
pr.set_position(0);
}
}

Expand All @@ -229,18 +232,29 @@ impl Client {
headers: &HeaderMap,
verb_label: &str,
) -> Result<Response> {
match self
.send_once(method.clone(), url.clone(), headers, verb_label)
.await
{
Ok(resp) => Ok(resp),
Err(_) if url.scheme() == "http" => {
let mut url = url;
url.set_scheme("https").unwrap();
self.send_once(method, url, headers, verb_label).await
}
Err(err) => Err(err),
}
Retry::spawn(
default_backoff_strategy(Settings::get().http_retries),
|| {
let method = method.clone();
let url = url.clone();
let headers = headers.clone();
async move {
match self
.send_once(method.clone(), url.clone(), &headers, verb_label)
.await
{
Ok(resp) => Ok(resp),
Err(_err) if url.scheme() == "http" => {
let mut url = url;
url.set_scheme("https").unwrap();
self.send_once(method, url, &headers, verb_label).await
}
Err(err) => Err(err),
}
}
},
)
.await
}

async fn send_once(
Expand Down Expand Up @@ -416,6 +430,12 @@ fn display_github_rate_limit(resp: &Response) {
}
}

fn default_backoff_strategy(retries: i64) -> impl Iterator<Item = std::time::Duration> {
ExponentialBackoff::from_millis(10)
.map(jitter)
.take(retries.max(0) as usize)
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down
Loading