fix(json-schema): remove settings/additionalProperties

[tpansino]

Resolves #6353

[jdx]

that's not the right way to fix this

[jdx]

sorry read the original thread, it seems more complicated than I thought

[cursor]

Bug: Schema Validation Error: Unintended Permissiveness

Removing additionalProperties: false from the settings object makes the schema overly permissive, allowing undefined or misspelled properties in settings configurations to pass validation. This could mask configuration errors, and the maintainer's comment suggests this isn't the intended fix.

schema/mise.json#L1730-L1731

mise/schema/mise.json

Lines 1730 to 1731 in d1a58bb

	"settings": {
	"$ref": "#/$defs/settings",

 

---

[jdx]

according to gpt-5 (which I think is right):

schema/mise.json: Dropping the additionalProperties: false that sits beside the $ref does not make validation stricter; it just removes a keyword that draft‑2019‑09 ignores in that position, so extra keys are still accepted. To fail on unknown settings you need the constraint inside the target schema itself (e.g. add additionalProperties: false to #/$defs/settings, or wrap the $ref in an allOf that adds that keyword). GitHub PR #6420
Next step suggestion
Move additionalProperties: false into #/$defs/settings (or equivalent) so the validator enforces it, then re-run your schema tests.

[tpansino]

Is this what you mean? I originally looked at the render.ts code, thinking I needed to fix it there, but then I saw it reads in the existing mise.json file and only updates specific sections that may change frequently. Is that right?

[jdx]

Yeah this looks correct to me