-
-
Notifications
You must be signed in to change notification settings - Fork 950
fix(backend): make pre-tools env vars available in postinstall hooks #6418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # Test that postinstall hooks have access to pre_tools environment variables | ||
|
|
||
| # Create a mise.toml with env vars that should be available before tools | ||
| cat <<EOF >mise.toml | ||
| [env] | ||
| # Environment variable without tools=true (should be available in postinstall) | ||
| PRE_TOOLS_VAR = "available_before_tools" | ||
|
|
||
| # Environment variable explicitly with tools=false | ||
| EXPLICIT_PRE_TOOLS = {value = "explicitly_pre_tools", tools = false} | ||
|
|
||
| # Environment variable with tools=true (should NOT be available in postinstall) | ||
| POST_TOOLS_VAR = {value = "available_after_tools", tools = true} | ||
|
|
||
| [tools] | ||
| dummy = { version = "latest", postinstall = "echo PRE_TOOLS_VAR=\$PRE_TOOLS_VAR; echo EXPLICIT_PRE_TOOLS=\$EXPLICIT_PRE_TOOLS; echo POST_TOOLS_VAR=\$POST_TOOLS_VAR" } | ||
| EOF | ||
|
|
||
| # Remove any existing dummy installation to force reinstall | ||
| rm -rf ~/.mise/installs/dummy | ||
|
|
||
| # Run install and capture output | ||
| output=$(mise install dummy 2>&1) | ||
|
|
||
| # Check that pre_tools environment variables are available in postinstall | ||
| if [[ $output == *"PRE_TOOLS_VAR=available_before_tools"* ]]; then | ||
| echo "✓ PRE_TOOLS_VAR is available in postinstall" | ||
| else | ||
| echo "✗ PRE_TOOLS_VAR is NOT available in postinstall" | ||
| echo "Output: $output" | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ $output == *"EXPLICIT_PRE_TOOLS=explicitly_pre_tools"* ]]; then | ||
| echo "✓ EXPLICIT_PRE_TOOLS is available in postinstall" | ||
| else | ||
| echo "✗ EXPLICIT_PRE_TOOLS is NOT available in postinstall" | ||
| echo "Output: $output" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # The post_tools var should be empty since it's marked as tools=true | ||
| if [[ $output == *"POST_TOOLS_VAR="* ]]; then | ||
| echo "✓ POST_TOOLS_VAR is empty as expected" | ||
| else | ||
| echo "✗ POST_TOOLS_VAR is not empty" | ||
| echo "Output: $output" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Verify that POST_TOOLS_VAR with tools=true is NOT available in postinstall hook | ||
| if [[ $output != *"POST_TOOLS_VAR=available_after_tools"* ]]; then | ||
| echo "✓ POST_TOOLS_VAR with tools=true is not available as expected" | ||
| else | ||
| echo "✗ POST_TOOLS_VAR with tools=true should not be available" | ||
| echo "Output: $output" | ||
| exit 1 | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
or_insertmethod will skip config environment variables if they already exist inexec_env. This may not be the intended behavior if config variables should take precedence over exec_env variables. Consider usingenv_vars.insert(k, v)instead to ensure config variables override exec_env variables.