feat(github): filter remote versions by version_prefix#6408
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements filtering of remote versions by version_prefix for the GitHub backend, matching the existing behavior in GitLab. The change ensures that when a version_prefix is configured, only releases with tags that start with that prefix are included in the available versions list.
- Adds version_prefix filtering logic to both GitLab and GitHub release processing
- Updates documentation to reflect that versions are filtered by prefix before stripping
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/backend/github.rs | Adds version_prefix filtering to both GitLab and GitHub release processing flows |
| docs/dev-tools/backends/gitlab.md | Updates documentation to clarify that filtering occurs before prefix stripping |
| docs/dev-tools/backends/github.md | Updates documentation to clarify that filtering occurs before prefix stripping |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+48
to
+51
| .filter(|r| { | ||
| opts.get("version_prefix") | ||
| .map_or(true, |p| r.tag_name.starts_with(p)) | ||
| }) |
There was a problem hiding this comment.
The filtering logic is duplicated between GitLab and GitHub branches. Consider extracting this into a helper method to reduce code duplication and improve maintainability.
jdx
added a commit
that referenced
this pull request
Sep 25, 2025
### 📦 Registry - fix mise-ghcup plugin managed tools descriptions by @risu729 in [#6411](#6411) - add Tinymist by @3w36zj6 in [#6412](#6412) - revert djinni backend to ubi by @risu729 in [#6410](#6410) ### 🚀 Features - **(github)** filter remote versions by version_prefix by @risu729 in [#6408](#6408) - Remove experimental labels for GitHub and HTTP backends by @Copilot in [#6415](#6415) ### 🧪 Testing - **(vfox)** replace flaky external tests with local dummy plugin by @jdx in [#6403](#6403) ### New Contributors - @Copilot made their first contribution in [#6415](#6415) Co-authored-by: mise-en-dev <release@mise.jdx.dev>
jdx
pushed a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix
bitwarden-secrets-managerin the registry.https://github.com/jdx/mise-versions/blob/main/docs/bitwarden-secrets-manager
I believe this is okay for most cases, and this matches with
tag_regexbehaviour in the ubi backend.