feat(aqua): support cosign for the binary, not only for checksums#6377
Closed
feat(aqua): support cosign for the binary, not only for checksums#6377
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends cosign verification support to work directly on binary files, not just on checksums. Previously, cosign verification was only available for checksum files through the AquaChecksum struct.
- Adds cosign verification as a standalone step in the verification pipeline
- Introduces AquaCosign struct as a top-level package configuration option
- Updates merging logic to handle the new cosign configuration structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/backend/aqua.rs | Adds cosign verification step to the main verification pipeline and implements verify_cosign method |
| crates/aqua-registry/src/types.rs | Adds AquaCosign field to AquaPackage and updates merging logic for configuration overrides |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Owner
|
bugbot run |
Contributor
Author
|
Sorry, I didn't notice it's already used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aqua allows cosign verification for binaries, not only for checksums.
https://aquaproj.github.io/docs/reference/registry-config/cosign
Currently, only these two packages are using it without
opts, which doesn't work now.https://github.com/aquaproj/aqua-registry/blob/9b2b783bba5c1637a5982f7c51ccd9d85af0e737/pkgs/k0sproject/k0s/registry.yaml#L69-L75
https://github.com/aquaproj/aqua-registry/blob/main/pkgs/technicalpickles/envsense/registry.yaml#L82-L93
cosign.optsis no longer supported since #6332, but this PR doesn't do anything about it.