Skip to content

feat(aqua): support cosign for the binary, not only for checksums#6377

Closed
risu729 wants to merge 7 commits intojdx:mainfrom
risu729:aqua-root-cosign
Closed

feat(aqua): support cosign for the binary, not only for checksums#6377
risu729 wants to merge 7 commits intojdx:mainfrom
risu729:aqua-root-cosign

Conversation

@risu729
Copy link
Contributor

@risu729 risu729 commented Sep 22, 2025

Aqua allows cosign verification for binaries, not only for checksums.
https://aquaproj.github.io/docs/reference/registry-config/cosign

Currently, only these two packages are using it without opts, which doesn't work now.
https://github.com/aquaproj/aqua-registry/blob/9b2b783bba5c1637a5982f7c51ccd9d85af0e737/pkgs/k0sproject/k0s/registry.yaml#L69-L75
https://github.com/aquaproj/aqua-registry/blob/main/pkgs/technicalpickles/envsense/registry.yaml#L82-L93

cosign.opts is no longer supported since #6332, but this PR doesn't do anything about it.

Copilot AI review requested due to automatic review settings September 22, 2025 14:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends cosign verification support to work directly on binary files, not just on checksums. Previously, cosign verification was only available for checksum files through the AquaChecksum struct.

  • Adds cosign verification as a standalone step in the verification pipeline
  • Introduces AquaCosign struct as a top-level package configuration option
  • Updates merging logic to handle the new cosign configuration structure

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/backend/aqua.rs Adds cosign verification step to the main verification pipeline and implements verify_cosign method
crates/aqua-registry/src/types.rs Adds AquaCosign field to AquaPackage and updates merging logic for configuration overrides

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@risu729 risu729 marked this pull request as draft September 22, 2025 14:50
@jdx
Copy link
Owner

jdx commented Sep 22, 2025

bugbot run

@risu729
Copy link
Contributor Author

risu729 commented Oct 5, 2025

@jdx Any reasons for not using the sigstore-rs crate?

Sorry, I didn't notice it's already used.

@jdx jdx closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants