Skip to content

chore(install.sh): add MISE_INSTALL_MUSL to force installing musl variants on Linux #6355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 2 commits into from
Sep 21, 2025
Merged

chore(install.sh): add MISE_INSTALL_MUSL to force installing musl variants on Linux #6355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d930ed
chore(install.sh): add MISE_INSTALL_MUSL to force installing musl var…
malept Sep 21, 2025
682d94a
chore: ensure musl is not selected for macOS
malept Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packaging/standalone/install.envsubst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,13 @@ get_os() {
get_arch() {
musl=""
if type ldd >/dev/null 2>/dev/null; then
libc=$(ldd /bin/ls | grep 'musl' | head -1 | cut -d ' ' -f1)
if [ -n "$libc" ]; then
if [ "${MISE_INSTALL_MUSL-}" = "1" ] || [ "${MISE_INSTALL_MUSL-}" = "true" ]; then
musl="-musl"
else
libc=$(ldd /bin/ls | grep 'musl' | head -1 | cut -d ' ' -f1)
if [ -n "$libc" ]; then
musl="-musl"
fi
Copy link

@cursor cursor bot Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Musl Variant Installation Ignored in Minimal Environments

The MISE_INSTALL_MUSL environment variable check is nested within the ldd availability check. This means it's ignored when ldd is unavailable, preventing users from explicitly forcing musl variants as intended, particularly in minimal environments.

Fix in Cursor Fix in Web

Copy link
Contributor Author

@malept malept Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is intentional, cursor bot. Otherwise MISE_INSTALL_MUSL=1 would incorrectly force musl on macOS (which does not have ldd or a musl variant).

fi
fi
arch="$(uname -m)"
Expand Down
Loading