Skip to content

chore: add schema linter #6267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 5 commits into from
Sep 11, 2025
Merged

chore: add schema linter #6267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2bae5b8
chore: add schema linter
risu729 Sep 11, 2025
2963d7f
[autofix.ci] apply automated fixes
autofix-ci[bot] Sep 11, 2025
0f1b3b1
fix(schema): fix errors
risu729 Sep 11, 2025
e9cea41
[autofix.ci] apply automated fixes
autofix-ci[bot] Sep 11, 2025
4a98354
chore: add type property in the schema
risu729 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mise.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,10 @@ checksum = "sha256:a9fe3ea2f86dfc72f6728417521ec9067b343277152b114f4e98d8cb0e263
size = 841408
url = "https://github.com/jqlang/jq/releases/download/jq-1.8.1/jq-macos-arm64"

[[tools."npm:ajv-cli"]]
version = "5.0.0"
backend = "npm:ajv-cli"

[[tools."npm:markdownlint-cli"]]
version = "0.45.0"
backend = "npm:markdownlint-cli"
Expand Down
1 change: 1 addition & 0 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ hk = "latest"
"jq" = "latest"
"npm:markdownlint-cli" = "latest"
"npm:prettier" = "3"
"npm:ajv-cli" = "latest"
"pipx:toml-sort" = "latest"
pkl = "latest"
pre-commit = "latest"
Expand Down
2 changes: 1 addition & 1 deletion schema/mise-task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$id": "https://mise.jdx.dev/schema/mise-task.json",
"$schema": "https://json-schema.org/draft-07/schema#",
"$schema": "https://json-schema.org/draft/2019-09/schema#",
"title": "mise-task-schema",
"type": "object",
"$defs": {
Expand Down
20 changes: 16 additions & 4 deletions schema/mise.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@
"type": "boolean"
},
"aqua": {
"type": "object",
"additionalProperties": false,
"properties": {
"baked_registry": {
Expand Down Expand Up @@ -339,6 +340,7 @@
"type": "string"
},
"cargo": {
"type": "object",
"additionalProperties": false,
"properties": {
"binstall": {
Expand Down Expand Up @@ -419,6 +421,7 @@
}
},
"dotnet": {
"type": "object",
"additionalProperties": false,
"properties": {
"package_flags": {
Expand Down Expand Up @@ -457,6 +460,7 @@
"type": "string"
},
"erlang": {
"type": "object",
"additionalProperties": false,
"properties": {
"compile": {
Expand Down Expand Up @@ -606,6 +610,7 @@
"enum": ["trace", "debug", "info", "warn", "error"]
},
"node": {
"type": "object",
"additionalProperties": false,
"properties": {
"compile": {
Expand All @@ -632,6 +637,7 @@
"type": "boolean"
},
"npm": {
"type": "object",
"additionalProperties": false,
"properties": {
"bun": {
Expand Down Expand Up @@ -669,6 +675,7 @@
"type": "boolean"
},
"pipx": {
"type": "object",
"additionalProperties": false,
"properties": {
"registry_url": {
Expand Down Expand Up @@ -697,6 +704,7 @@
"deprecated": true
},
"python": {
"type": "object",
"additionalProperties": false,
"properties": {
"compile": {
Expand Down Expand Up @@ -815,6 +823,7 @@
"type": "boolean"
},
"ruby": {
"type": "object",
"additionalProperties": false,
"properties": {
"apply_patches": {
Expand Down Expand Up @@ -855,6 +864,7 @@
}
},
"rust": {
"type": "object",
"additionalProperties": false,
"properties": {
"cargo_home": {
Expand All @@ -876,6 +886,7 @@
"type": "boolean"
},
"sops": {
"type": "object",
"additionalProperties": false,
"properties": {
"age_key": {
Expand Down Expand Up @@ -903,6 +914,7 @@
}
},
"status": {
"type": "object",
"additionalProperties": false,
"properties": {
"missing_tools": {
Expand All @@ -926,6 +938,7 @@
}
},
"swift": {
"type": "object",
"additionalProperties": false,
"properties": {
"gpg_verify": {
Expand Down Expand Up @@ -1428,6 +1441,7 @@
]
},
"install_env": {
"type": "object",
"additionalProperties": {
"oneOf": [
{
Expand Down Expand Up @@ -1532,10 +1546,7 @@
"properties": {
"run": {
"type": "string",
"description": "script to run when file changes",
"items": {
"type": "string"
}
"description": "script to run when file changes"
},
"patterns": {
"type": "array",
Expand Down Expand Up @@ -1647,6 +1658,7 @@
"$ref": "#/$defs/watch_files"
},
"_": {
"type": "object",
"additionalProperties": true
}
}
Expand Down
2 changes: 2 additions & 0 deletions schema/mise.plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
},
"list-bin-paths": {
"description": "configuration for bin/list-bin-paths script",
"type": "object",
"additionalProperties": false,
"properties": {
"cache-key": {
Expand All @@ -43,6 +44,7 @@
},
"exec-env": {
"description": "configuration for bin/exec-env script",
"type": "object",
"additionalProperties": false,
"properties": {
"cache-key": {
Expand Down
6 changes: 6 additions & 0 deletions tasks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,12 @@ Lint Markdown files

Lint using ripgrep

## `lint:schema`

- **Usage**: `lint:schema`

Lint schemas

## `lint:toml`

- **Usage**: `lint:toml`
Expand Down
7 changes: 7 additions & 0 deletions xtasks/lint/schema
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/usr/bin/env bash
#MISE description="Lint schemas"
set -euo pipefail

ajv compile -s schema/mise.json --spec=draft2019 --strict=true
ajv compile -s schema/mise-task.json --spec=draft2019 --strict=true
ajv compile -s schema/mise.plugin.json --spec=draft2020 --strict=true
Copy link

Copilot AI Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent JSON Schema specification versions are being used. Lines 5-6 use draft2019 while line 7 uses draft2020. Consider standardizing on a single specification version unless there's a specific requirement for different versions.

Suggested change
ajv compile -s schema/mise.plugin.json --spec=draft2020 --strict=true
ajv compile -s schema/mise.plugin.json --spec=draft2019 --strict=true

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@risu729 risu729 Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional. It has:

  "$schema": "https://json-schema.org/draft/2020-12/schema",

1 change: 1 addition & 0 deletions xtasks/render/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ for (const key in doc) {
} else {
for (const subkey in props) {
settings[key] = settings[key] || {
type: "object",
additionalProperties: false,
description: props.description,
properties: {},
Expand Down
Loading