Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the MISE_TASK_UNNEST functionality from the codebase, which was previously used to handle nested task output formatting. The removal eliminates complex regex-based unnesting logic that is no longer necessary.
- Removes MISE_TASK_LEVEL environment variable and related logic
- Simplifies task prefix formatting by removing unnesting conditionals
- Eliminates regex-based output processing in prefix macros
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/task/mod.rs | Removes conditional MISE_TASK_UNNEST prefix formatting logic |
| src/output.rs | Removes regex and unnesting logic from prefix printing macros |
| src/env.rs | Removes MISE_TASK_LEVEL environment variable definition |
| src/cli/run.rs | Removes MISE_TASK_LEVEL checks and environment variable setting |
| e2e/tasks/test_task_unnest | Deletes entire test file for unnesting functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -1,41 +1,19 @@ | |||
| use regex::Regex; | |||
| use std::collections::HashSet; | |||
There was a problem hiding this comment.
The regex import was removed but the HashSet import remains. Verify that HashSet is still used elsewhere in this file, otherwise it should also be removed.
Suggested change
| use std::collections::HashSet; |
It is no longer necessary that we have #6212
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.4 x -- echo |
18.5 ± 0.3 | 17.9 | 21.0 | 1.00 ± 0.02 |
mise x -- echo |
18.4 ± 0.3 | 18.0 | 21.9 | 1.00 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.4 env |
17.9 ± 0.3 | 17.4 | 21.5 | 1.00 |
mise env |
18.0 ± 0.5 | 17.4 | 23.8 | 1.01 ± 0.03 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.4 hook-env |
17.5 ± 0.6 | 17.0 | 25.7 | 1.00 |
mise hook-env |
17.7 ± 0.4 | 17.1 | 20.3 | 1.01 ± 0.04 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.9.4 ls |
15.9 ± 0.2 | 15.5 | 16.7 | 1.00 |
mise ls |
16.0 ± 0.2 | 15.6 | 17.3 | 1.00 ± 0.02 |
xtasks/test/perf
| Command | mise-2025.9.4 | mise | Variance |
|---|---|---|---|
| install (cached) | 162ms | ✅ 100ms | +62% |
| ls (cached) | 61ms | 60ms | +1% |
| bin-paths (cached) | 64ms | 64ms | +0% |
| task-ls (cached) | 462ms | 464ms | +0% |
✅ Performance improvement: install cached is 62%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is no longer necessary that we have #6212