Skip to content

fix: mise activate not working on powershell v5 #6168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 8 commits into from
Sep 5, 2025
Merged

fix: mise activate not working on powershell v5 #6168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
69dfc70
fix: windows powershell activate now works on v5 (vendored with windows)
L0RD-ZER0 Sep 1, 2025
7c1fb75
fix: update powershell snapshot to use new script
L0RD-ZER0 Sep 1, 2025
5fcfd84
fix: powershell version check equality and quoting
L0RD-ZER0 Sep 1, 2025
0e76994
fix: update powershell script snapshot
L0RD-ZER0 Sep 1, 2025
9ee32d5
fix: address casing convention for powershell
L0RD-ZER0 Sep 1, 2025
97dfe24
fix: robust array indexes for slicing on remaining args
L0RD-ZER0 Sep 1, 2025
b636b20
fix: handle array processing when arguments are less than expected
L0RD-ZER0 Sep 1, 2025
c7d0c4c
fix: snapshot indentation
L0RD-ZER0 Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 27 additions & 12 deletions src/shell/pwsh.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ impl Shell for Pwsh {
$env:__MISE_ORIG_PATH = $env:PATH

function mise {{
[CmdletBinding()]
param(
[Parameter(ValueFromRemainingArguments=$true)] # Allow any number of arguments, including none
[string[]] $arguments
)

$previous_out_encoding = $OutputEncoding
$previous_console_out_encoding = [Console]::OutputEncoding
$OutputEncoding = [Console]::OutputEncoding = [Text.UTF8Encoding]::UTF8
Expand All @@ -33,38 +39,41 @@ impl Shell for Pwsh {
[Console]::OutputEncoding = $previous_console_out_encoding
}}

# Read line directly from input to workaround powershell input parsing for functions
$code = [System.Management.Automation.Language.Parser]::ParseInput($MyInvocation.Statement.Substring($MyInvocation.OffsetInLine - 1), [ref]$null, [ref]$null)
$myLine = $code.Find({{ $args[0].CommandElements }}, $true).CommandElements | ForEach-Object {{ $_.ToString() }} | Join-String -Separator ' '
$command, [array]$arguments = Invoke-Expression ('Write-Output -- ' + $myLine)

if ($null -eq $arguments) {{
if ($arguments.count -eq 0) {{
& {exe}
_reset_output_encoding
return
}} elseif ($arguments -contains '-h' -or $arguments -contains '--help') {{
& {exe} $arguments
& {exe} @arguments
_reset_output_encoding
return
}}
}}

$command = $arguments[0]
$arguments = $arguments[1..$arguments.Length]
if ($arguments.Length -gt 1) {{
$remainingArgs = $arguments[1..($arguments.Length - 1)]
}} else {{
$remainingArgs = @()
}}

switch ($command) {{
{{ $_ -in 'deactivate', 'shell', 'sh' }} {{
& {exe} $command $arguments | Out-String | Invoke-Expression -ErrorAction SilentlyContinue
& {exe} $command @remainingArgs | Out-String | Invoke-Expression -ErrorAction SilentlyContinue
_reset_output_encoding
}}
default {{
& {exe} $command $arguments
& {exe} $command @remainingArgs
$status = $LASTEXITCODE
if ($(Test-Path -Path Function:\_mise_hook)){{
_mise_hook
}}
_reset_output_encoding
# Pass down exit code from mise after _mise_hook
pwsh -NoProfile -Command exit $status
if ($PSVersionTable.PSVersion.Major -ge 7) {{
pwsh -NoProfile -Command exit $status
}} else {{
powershell -NoProfile -Command exit $status
}}
}}
}}
}}
Expand All @@ -80,6 +89,12 @@ impl Shell for Pwsh {
}}

function __enable_mise_chpwd{{
if ($PSVersionTable.PSVersion.Major -lt 7) {{
if ($env:MISE_PWSH_CHPWD_WARNING -ne '0') {{
Write-Warning "mise: chpwd functionality requires PowerShell version 7 or higher. Your current version is $($PSVersionTable.PSVersion). You can add `$env:MISE_PWSH_CHPWD_WARNING=0` to your environment to disable this warning."
}}
return
}}
if (-not $__mise_pwsh_chpwd){{
$Global:__mise_pwsh_chpwd= $true
$_mise_chpwd_hook = [EventHandler[System.Management.Automation.LocationChangedEventArgs]] {{
Expand Down
39 changes: 27 additions & 12 deletions src/shell/snapshots/mise__shell__pwsh__tests__activate.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ $env:MISE_SHELL = 'pwsh'
$env:__MISE_ORIG_PATH = $env:PATH

function mise {
[CmdletBinding()]
param(
[Parameter(ValueFromRemainingArguments=$true)] # Allow any number of arguments, including none
[string[]] $arguments
)

$previous_out_encoding = $OutputEncoding
$previous_console_out_encoding = [Console]::OutputEncoding
$OutputEncoding = [Console]::OutputEncoding = [Text.UTF8Encoding]::UTF8
Expand All @@ -15,38 +21,41 @@ function mise {
[Console]::OutputEncoding = $previous_console_out_encoding
}

# Read line directly from input to workaround powershell input parsing for functions
$code = [System.Management.Automation.Language.Parser]::ParseInput($MyInvocation.Statement.Substring($MyInvocation.OffsetInLine - 1), [ref]$null, [ref]$null)
$myLine = $code.Find({ $args[0].CommandElements }, $true).CommandElements | ForEach-Object { $_.ToString() } | Join-String -Separator ' '
$command, [array]$arguments = Invoke-Expression ('Write-Output -- ' + $myLine)

if ($null -eq $arguments) {
if ($arguments.count -eq 0) {
& /some/dir/mise
_reset_output_encoding
return
} elseif ($arguments -contains '-h' -or $arguments -contains '--help') {
& /some/dir/mise $arguments
& /some/dir/mise @arguments
_reset_output_encoding
return
}
}

$command = $arguments[0]
$arguments = $arguments[1..$arguments.Length]
if ($arguments.Length -gt 1) {
$remainingArgs = $arguments[1..($arguments.Length - 1)]
} else {
$remainingArgs = @()
}

switch ($command) {
{ $_ -in 'deactivate', 'shell', 'sh' } {
& /some/dir/mise $command $arguments | Out-String | Invoke-Expression -ErrorAction SilentlyContinue
& /some/dir/mise $command @remainingArgs | Out-String | Invoke-Expression -ErrorAction SilentlyContinue
_reset_output_encoding
}
default {
& /some/dir/mise $command $arguments
& /some/dir/mise $command @remainingArgs
$status = $LASTEXITCODE
if ($(Test-Path -Path Function:\_mise_hook)){
_mise_hook
}
_reset_output_encoding
# Pass down exit code from mise after _mise_hook
pwsh -NoProfile -Command exit $status
if ($PSVersionTable.PSVersion.Major -ge 7) {
pwsh -NoProfile -Command exit $status
} else {
powershell -NoProfile -Command exit $status
}
}
}
}
Expand All @@ -58,6 +67,12 @@ function Global:_mise_hook {
}

function __enable_mise_chpwd{
if ($PSVersionTable.PSVersion.Major -lt 7) {
if ($env:MISE_PWSH_CHPWD_WARNING -ne '0') {
Write-Warning "mise: chpwd functionality requires PowerShell version 7 or higher. Your current version is $($PSVersionTable.PSVersion). You can add `$env:MISE_PWSH_CHPWD_WARNING=0` to your environment to disable this warning."
}
return
}
if (-not $__mise_pwsh_chpwd){
$Global:__mise_pwsh_chpwd= $true
$_mise_chpwd_hook = [EventHandler[System.Management.Automation.LocationChangedEventArgs]] {
Expand Down
Loading