fix: version prefix detection

[risu729]

Resolves #5935 (comment).

Since we have this, we cannot simply treat all non-numeric characters in the front as a prefix.

version_prefix: mountpoint-s3-

https://github.com/aquaproj/aqua-registry/blob/4775b3bb05d5526199c87270227e3e1dc189b16e/pkgs/awslabs/mountpoint-s3/registry.yaml#L8

The prefix regexes are introduced in #4340 and #1392. I think this can safely replace those.

[risu729]

The test for this fails, but I didn't change any, so I guess it was broken since the original PR #2889.

given v: "1.2-3a4" return ["1", ".2", "-3", "a4"]

I'm not sure why we need this, but can I fix the test to match the current behaviour?
It now returns ["1", ".2", "-3a4"].

[Copilot]

Pull Request Overview

This PR fixes version prefix detection by replacing a regex-based approach with a more sophisticated parsing mechanism that handles complex version prefixes like "mountpoint-s3-". The change addresses an issue where tools with multi-part prefixes weren't being correctly parsed.

• Introduces a new semver module with split_version_prefix function to properly handle complex version prefixes
• Replaces regex-based prefix detection with character-by-character parsing that respects delimiters
• Moves the chunkify_version function from outdated_info.rs to the new semver module for better organization

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File	Description
src/semver.rs	New module containing version parsing utilities with comprehensive test coverage
src/toolset/outdated_info.rs	Removes duplicated chunkify_version function and updates imports
src/aqua/aqua_registry.rs	Replaces regex-based prefix detection with new split_version_prefix function
src/main.rs	Adds the new semver module declaration

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The comment example shows incorrect output. According to the test on line 90, the actual output for "1.2-3a4" is ["1", ".2", "-3a4"], but the comment shows "-3a4" as the last element instead of "-3a4".

[jdx]

bugbot run

[cursor]

Bug: Unicode Indexing Mismatch Causes Panic

The split_version_prefix function incorrectly mixes byte indices from char_indices() with character indices for chars().nth(). When char_indices() returns a byte index i for a digit, version.chars().nth(i - 1) attempts to access the character at character position i - 1. For strings containing multi-byte Unicode characters, this can cause unwrap() to panic because i - 1 (a byte index) may exceed the actual character count, leading chars().nth() to return None. It can also result in incorrect prefix detection if a panic does not occur.

[jdx]

I don't think this is a concern, version numbers probably don't support unicode anyways

[risu729]

Yes, and also I think it's incorrect.
char_indices doesn't return byte indices.

fn main() {
    let str = "😀1㐂";
    println!("{:?}", str.char_indices());
    println!("{:?}", str.chars());
}

CharIndices { front_offset: 0, iter: Chars(['😀', '1', '㐂']) }
Chars(['😀', '1', '㐂'])