fix(settings): respect os in settings #5488
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MISE_OSorsettings.osis added in #4224, but onlytest-toolrespected it.This PR replaces
env::consts::OSorcfg!(target_os)withsettings.os().Since this will move the os detection from compile-time to runtime, it might slow down the execution.
Also, in most cases, setting
MISE_OSdoesn't work as expected.This PR aims only to make the code consistent.
It might make OS-dependent tests a bit easier locally.