Skip to content

feat(registry): add PostgreSQL aqua backend and aliases#5462

Closed
yashikota wants to merge 3 commits into
jdx:mainfrom
yashikota:postgres-aqua
Closed

feat(registry): add PostgreSQL aqua backend and aliases#5462
yashikota wants to merge 3 commits into
jdx:mainfrom
yashikota:postgres-aqua

Conversation

@yashikota

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

If you are adding a new tool to mise, note the following:

  • New asdf plugins are not accepted
  • Tools may be rejected if they are not notable
  • A test is required in registry.toml

@yashikota

Copy link
Copy Markdown
Contributor Author

The CI job is currently failing with

0: failed to install aqua:bitwarden/clients@cli-v2025.6.0,

which appears to be unrelated to the changes in this PR.
Could someone take a look and address the issue? Thanks!

@yashikota

Copy link
Copy Markdown
Contributor Author

I’m also seeing the following error:

  mise ERROR postgres: 
     0: failed to install aqua:theseus-rs/postgresql-binaries@17.5
     1: HTTP status client error (404 Not Found) for url (https://api.github.com/repos/theseus-rs/postgresql-binaries/releases/tags/17.5)
     2: HTTP status client error (404 Not Found) for url (https://api.github.com/repos/theseus-rs/postgresql-binaries/releases/tags/v17.5)

The reason for the 404 is that the correct version tag is 17.5.0, not 17.5.
However, I’m not sure how to fix this in the current setup.
Could someone help me with this?

@risu729

risu729 commented Jun 29, 2025

Copy link
Copy Markdown
Contributor

The CI job is currently failing with

0: failed to install aqua:bitwarden/clients@cli-v2025.6.0,

which appears to be unrelated to the changes in this PR. Could someone take a look and address the issue? Thanks!

I opened an issue in the aqua-registry. #5462 (comment)
I'll fix it, but we only update the aqua-registry in the release, so I think we need to disable the test for now.
I disabled it in #5463, so this PR can be merged after it by updating the branch.

@yashikota

Copy link
Copy Markdown
Contributor Author

Thanks for the clarification and the quick action!
I'll wait for #5463 to be merged and then update this branch.

@risu729

risu729 commented Jun 29, 2025

Copy link
Copy Markdown
Contributor

Since theseus-rs/postgresql-binaries is a third-party release of the prebuilt binaries, I don't think we should include it in the default registry in terms of security concerns.

Regarding the versioning, they version the releases with <postgres major>.<postgres minor>.<release>, where <release> is the build version.
https://github.com/theseus-rs/postgresql-binaries?tab=readme-ov-file#versioning
So, we need to use their versions (e.g. 17.5.0) instead of the postgres version (e.g. 17.5).

However, mise-versions contains the postgres versions, so the test is failing.
We can ignore the error with use_versions_host set to false for now, and the version list in mise-versions will be updated when this change is included in the new release.
However, it would be a breaking change to users using the older version of mise because mise install postgres@17.5.0 fails.

Just as a note, this test passes (with use_versions_host=false).

postgres.test = ["psql --version", "psql (PostgreSQL) {{version | split(pat='.') | slice(end=2) | join(sep='.')}}"]

@yashikota

Copy link
Copy Markdown
Contributor Author

Thank you for your feedback.

Regarding the security concerns, I completely understand your point. However, with mise-postgres, the build runs locally in my environment, which takes quite a long time to install. Also, theseus-rs/postgresql-binaries has all of its build scripts and GitHub Actions publicly available, and the releases are built via Actions as well. So I believe it has a certain level of trustworthiness.

I also appreciate your advice about the versioning and testing. I agree that introducing a breaking change should be avoided, and it would be better to align the versioning with the official PostgreSQL versions. I’ll open an issue about this on the theseus-rs.

As a temporary workaround, I think stripping the trailing .0 from the version should make it work as well. What do you think about that approach?

@jdx

jdx commented Jul 1, 2025

Copy link
Copy Markdown
Owner

yeah I think I agree with @risu729 regarding the supply chain issue with this. A repo with 22 stars just isn't something I would want to start using by default.

@jdx jdx closed this Jul 1, 2025
@yashikota yashikota deleted the postgres-aqua branch July 1, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants