fix(aqua): parse consecutive pipes in aqua templates#5385

Merged

jdx merged 3 commits into

risu729:fix-aqua-template-pipe

Jun 21, 2025

risu729 commented Jun 21, 2025 •

edited

Loading

Contributor

Resolves #5382.

If the templates have multiple pipes, only the first and last functions are parsed correctly.

trimV .Version | replace "-RC" "-rc-" | replace "-M" "-milestone-"

This is parsed as 9.0.0-RC1 if .Version is 9.0.0-RC1, but should be parsed as 9.0.0-rc-1.

This PR fixes the issue by adding in_pipe state in the parse function.

risu729 added 3 commits

June 21, 2025 13:19


          fix(aqua): parse consecutive pipes in aqua templates

e7ff4de


          test(aqua): add test for multiple pipes

5bf7d74


          test(aqua): fix test

22b9101

jdx merged commit 9de6b73 into jdx:main

17 checks passed

risu729 deleted the fix-aqua-template-pipe branch

June 21, 2025 12:56

mise-en-dev mentioned this pull request

chore: release 2025.6.6 #5363

Merged

jdx pushed a commit that referenced this pull request


          chore: release 2025.6.6 (#5363)

36d1126

### 🚀 Features

- **(registry)** add wash by [@jtakakura](https://github.com/jtakakura)
in [#5386](#5386)

### 🐛 Bug Fixes

- **(aqua)** parse consecutive pipes in aqua templates by
[@risu729](https://github.com/risu729) in
[#5385](#5385)
- **(aqua)** use versions list to install correct version by
[@risu729](https://github.com/risu729) in
[#5371](#5371)
- **(registry)** talosctl use aqua by
[@mangkoran](https://github.com/mangkoran) in
[#5348](#5348)
- **(registry)** use aqua backend for watchexec by
[@risu729](https://github.com/risu729) in
[#5390](#5390)
- **(shim)** improve resolve_symlink for Windows by
[@qianlongzt](https://github.com/qianlongzt) in
[#5361](#5361)
- add compression-zip-deflate feature on self_update crate for windows
target by [@roele](https://github.com/roele) in
[#5391](#5391)
- suppress hint on 'cargo search mise' command by
[@roele](https://github.com/roele) in
[#5400](#5400)

### 📚 Documentation

- Fix typo in README.md - Install mise by
[@cytsai1008](https://github.com/cytsai1008) in
[#5366](#5366)
- Document trivial task syntax by
[@JayBazuzi](https://github.com/JayBazuzi) in
[#5352](#5352)

### 🧪 Testing

- **(registry)** fix vultr test by
[@risu729](https://github.com/risu729) in
[#5372](#5372)

### 📦️ Dependency Updates

- update autofix-ci/action action to v1.3.2 by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#5377](#5377)
- update docker/setup-buildx-action digest to e468171 by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#5376](#5376)

### Chore

- update expr-lang crate to v0.3.2 by
[@risu729](https://github.com/risu729) in
[#5364](#5364)
- show curl error by [@jdx](https://github.com/jdx) in
[729aa4a](729aa4a)
- fix latest version fetch by [@jdx](https://github.com/jdx) in
[729aadc](729aadc)
- update vfox.rs crate to v1.0.3 by
[@risu729](https://github.com/risu729) in
[#5393](#5393)
- updated deps by [@jdx](https://github.com/jdx) in
[#5403](#5403)

### Ci

- use cargo info to retrieve latest mise version by
[@risu729](https://github.com/risu729) in
[#5401](#5401)

### New Contributors

- @jtakakura made their first contribution in
[#5386](#5386)
- @JayBazuzi made their first contribution in
[#5352](#5352)
- @cytsai1008 made their first contribution in
[#5366](#5366)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet