docs(registry): fix links of registry#5266
Merged
Merged
Conversation
risu729
force-pushed
the
fix-registry-urls
branch
from
6608f1c to
3a34557
Compare
risu729
force-pushed
the
fix-registry-urls
branch
from
9b0294e to
03360da
Compare
This was referenced Jun 3, 2025
jdx
pushed a commit
that referenced
this pull request
Jun 3, 2025
In #5266, `tetratelabs/func-e` was added, but it didn't have the backend. Since `aqua-registry` doesn't contain it, I guess it was meant to use `ubi`. I confirmed it can be installed.
jdx
pushed a commit
that referenced
this pull request
Jun 4, 2025
My apologies, #5266 didn't work, so this is the follow-up. I confirmed all links (except for 1password) work with `mise exec lychee -- lychee docs/.vitepress/dist/registry.html` (with #5271 and #5273). - Since `aqua:1password/cli` uses `http` type, we should link to https://developer.1password.com/ I guess, but didn't know where to declare it. PR added the package: aquaproj/aqua-registry#26217 https://github.com/aquaproj/aqua-registry/blob/main/pkgs/1password/cli/registry.yaml - I switched to `kubernetes/kubernetes/kubectl-convert` from its alias `kubernetes/kubectl-convert`, to build the correct url. https://github.com/aquaproj/aqua-registry/blob/main/pkgs/kubernetes/kubernetes/kubectl-convert/registry.yaml - `dotnet`, `gem`, `spm` backends are not used in the registry currently, so I ignored them. I confirmed the page can be rendered even if `url` is an empty string. --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
jdx
pushed a commit
that referenced
this pull request
Jun 9, 2025
### 🚀 Features - **(aqua)** support no_asset and error_message by [@risu729](https://github.com/risu729) in [#5303](#5303) - **(registry)** use ubi backend for func-e by [@risu729](https://github.com/risu729) in [#5273](#5273) ### 🐛 Bug Fixes - **(task)** use empty string for the default value of option by [@risu729](https://github.com/risu729) in [#5309](#5309) ### 📚 Documentation - **(registry)** fix links of registry by [@risu729](https://github.com/risu729) in [#5266](#5266) - **(registry)** fix links to tools by [@risu729](https://github.com/risu729) in [#5272](#5272) ### 🧪 Testing - **(registry)** fix test typos by [@risu729](https://github.com/risu729) in [#5269](#5269) ### 🛡️ Security - **(security)** prevent untarring outside expected path by [@jdx](https://github.com/jdx) in [#5279](#5279)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5265.
aqua:pipe-cd/pipecd/pipectllinked to https://github.com/pipe-cd/pipecd/pipectl, so fixed it to only use the repo name instead of the full aqua package name: https://github.com/pipe-cd/pipecd(This doesn't support aqua packages starting with
gitlab.com, but there are no such packages in the registry now.)Also,
asdf:https://gitlab.com/td7x/asdf/adr-toolspointed https://github.com/https, so useslugas is if it's a url (starting withhttp).