fix: ensure config is always wrapped in Result#5223
Merged
Merged
Conversation
|
If you are adding a new tool to mise, note the following:
|
|
| Command | mise | mise-2025.5.15 |
|---|---|---|
| install (uncached) | 1040ms | 855ms |
| install (cached) | ✅ 143ms | 215ms |
| ls (uncached) | 723ms | 717ms |
| ls (cached) | 103ms | 103ms |
| bin-paths (uncached) | 728ms | |
| bin-paths (cached) | 91ms | 86ms |
| task-ls (uncached) | 3457ms | 3075ms |
| task-ls (cached) | 285ms | 287ms |
✅ Performance improvement: install cached is 50%
Hyperfine Performance
mise x -- echo
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.5.15 x -- echo |
48.5 ± 1.7 | 45.4 | 62.8 | 1.00 |
mise x -- echo |
49.4 ± 1.7 | 46.4 | 56.5 | 1.02 ± 0.05 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.5.15 env |
48.6 ± 1.9 | 45.2 | 64.5 | 1.00 |
mise env |
49.0 ± 1.5 | 45.8 | 55.1 | 1.01 ± 0.05 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.5.15 hook-env |
48.3 ± 1.8 | 45.3 | 62.6 | 1.00 |
mise hook-env |
48.8 ± 1.6 | 45.8 | 55.9 | 1.01 ± 0.05 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2025.5.15 ls |
71.0 ± 2.0 | 67.9 | 87.6 | 1.00 |
mise ls |
71.6 ± 2.2 | 68.4 | 96.1 | 1.01 ± 0.04 |
jdx
force-pushed
the
config-get
branch
9 times, most recently
from
4887b32 to
a7bc334
Compare
jdx
force-pushed
the
config-get
branch
2 times, most recently
from
e3b0907 to
97b2b1a
Compare
jdx
pushed a commit
that referenced
this pull request
May 29, 2025
### 🐛 Bug Fixes - ensure config is always wrapped in Result by [@jdx](https://github.com/jdx) in [#5223](#5223) ### ⚡ Performance - improve init performance by [@jdx](https://github.com/jdx) in [#5231](#5231) ### Chore - remove hyperfine from main builds by [@jdx](https://github.com/jdx) in [#5226](#5226)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5218
Fixes #5215