Skip to content

fix: output was silenced on task fail with keep-order #5175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 2 commits into from
May 25, 2025
Merged

fix: output was silenced on task fail with keep-order #5175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
157e71f
move output before exit on fail
artemisart May 25, 2025
ebceea8
assert_fail
artemisart May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions e2e/tasks/test_task_keep_order
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,11 @@ EOF
assert "mise run -o keep-order all" "[a] a
[b] b
[c] c"

cat <<EOF >mise.toml
tasks.a = "echo a"
tasks.b = "echo b ; exit 1"
tasks.all.depends = ['a', 'b']
EOF
assert_fail "mise run -o keep-order all" "[a] a
[b] b"
45 changes: 24 additions & 21 deletions src/cli/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,21 +369,6 @@ impl Run {
}
});

if let Some((task, status)) = self.failed_tasks.lock().unwrap().first() {
let prefix = task.estyled_prefix();
self.eprint(
task,
&prefix,
&format!("{} task failed", style::ered("ERROR")),
);
exit(*status);
}

if self.timings() && num_tasks > 1 && *env::MISE_TASK_LEVEL == 0 {
let msg = format!("Finished in {}", time::format_duration(timer.elapsed()));
eprintln!("{}", style::edim(msg));
};

if self.output(None) == TaskOutput::KeepOrder {
// TODO: display these as tasks complete in order somehow rather than waiting until everything is done
let output = self.keep_order_output.lock().unwrap();
Expand All @@ -404,6 +389,19 @@ impl Run {
}
}
}
if self.timings() && num_tasks > 1 && *env::MISE_TASK_LEVEL == 0 {
let msg = format!("Finished in {}", time::format_duration(timer.elapsed()));
eprintln!("{}", style::edim(msg));
};
if let Some((task, status)) = self.failed_tasks.lock().unwrap().first() {
let prefix = task.estyled_prefix();
self.eprint(
task,
&prefix,
&format!("{} task failed", style::ered("ERROR")),
);
exit(*status);
}
time!("parallelize_tasks done");

Ok(())
Expand Down Expand Up @@ -496,7 +494,7 @@ impl Run {
}
}

if self.timings() && (task.file.as_ref().is_some() || !task.run().is_empty()) {
if self.task_timings() && (task.file.as_ref().is_some() || !task.run().is_empty()) {
self.eprint(
task,
&prefix,
Expand Down Expand Up @@ -1003,11 +1001,16 @@ impl Run {
}

fn timings(&self) -> bool {
!self.quiet(None)
&& !self.no_timings
&& SETTINGS
.task_timings
.unwrap_or(self.output == Some(TaskOutput::Prefix))
!self.quiet(None) && !self.no_timings
}

fn task_timings(&self) -> bool {
self.timings()
&& SETTINGS.task_timings.unwrap_or(
self.output == Some(TaskOutput::Prefix)
|| self.output == Some(TaskOutput::Timed)
|| self.output == Some(TaskOutput::KeepOrder),
)
}

fn fetch_tasks(&self, tasks: &mut Vec<Task>) -> Result<()> {
Expand Down