Skip to content

fix(java): filter out JetBrains releases with features#4970

Merged
jdx merged 2 commits into
jdx:mainfrom
roele:issues/4969
May 1, 2025
Merged

fix(java): filter out JetBrains releases with features#4970
jdx merged 2 commits into
jdx:mainfrom
roele:issues/4969

Conversation

@roele

@roele roele commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Java version data for JetBrains is available for a couple months but contains various packages per os/arch which leads to mise picking the wrong ones at random. Packages with features debug, fastdebug, jcef, freetype etc. should be filtered out.

See #4969

@jdx jdx enabled auto-merge (squash) April 29, 2025 17:52
auto-merge was automatically disabled May 1, 2025 07:43

Head branch was pushed to by a user without write access

@jdx jdx merged commit 4c36238 into jdx:main May 1, 2025
18 checks passed
@roele roele deleted the issues/4969 branch May 3, 2025 10:42
jdx pushed a commit that referenced this pull request May 3, 2025
### 🚀 Features

- **(registry)** add luau by [@rhanneken](https://github.com/rhanneken)
in [#4993](#4993)
- **(registry)** add numbat by [@risu729](https://github.com/risu729) in
[#4980](#4980)
- add check flag for the fmt command by
[@roele](https://github.com/roele) in
[#4972](#4972)
- use aqua for btop by [@jdx](https://github.com/jdx) in
[#4979](#4979)

### 🐛 Bug Fixes

- **(java)** filter out JetBrains releases with features by
[@roele](https://github.com/roele) in
[#4970](#4970)
- fix deadlocks caused by uv_venv_auto by
[@risu729](https://github.com/risu729) in
[#4900](#4900)

### 📚 Documentation

- Put dot in dotfile example by
[@ryanbrainard](https://github.com/ryanbrainard) in
[#4965](#4965)

### Chore

- only use mold when available by [@jdx](https://github.com/jdx) in
[#4978](#4978)
- enable clearing screen for confirm and dialog by
[@roele](https://github.com/roele) in
[#4990](#4990)

### New Contributors

- @rhanneken made their first contribution in
[#4993](#4993)
- @ryanbrainard made their first contribution in
[#4965](#4965)
@bric3

bric3 commented May 14, 2025

Copy link
Copy Markdown

@roele FYI, for Jetbrains Plugin development the jcef variant should be used. I'm not sure about the other variants, some might be useful depending on the platform.

Wouldn't it be possible to express this as an option like this ?

mise use java\[variant=jcef\]@jetbrains-21.0.7b968.13

Anyway such variant option/dimension could be useful in other places like the early access, e.g. to distinguish loom, valhalla, lilliput, leyden, babylon, etc.

@roele

roele commented May 14, 2025

Copy link
Copy Markdown
Contributor Author

@bric3 The current JDK version data has a features property which for JetBrains has jcef and/or fastdebug options. Usually we expose some of the features as part of the vendor string, Liberica for example has liberica-lite-21.0.7+9. For JetBrains this would become jetbrains-jcef-21.0.7b968.13. Unfortunately the features property in the current version data is not always properly set.

There are plans to switch to another version source for Java which is more tailored to mise and should be a tiny bit more consistent in this regard.

@bric3

bric3 commented May 14, 2025

Copy link
Copy Markdown

Nice do you have an issue/discussion to follow?

@roele

roele commented May 14, 2025

Copy link
Copy Markdown
Contributor Author

No but i will push a draft PR in the next few days with required changes. Will need to coordinate with Jeff about the switch-over and new URL etc.

The change will be mostly compatible with a few changes that can/could be considered breaking changes.

  • removed AdoptOpenJDK
  • use of proper checksums from vendor
  • JetBrains versioning will use suffix for builds (e.g. 21.0.7-b968.13 instead of 21.0.7b968.13)
  • few missing patch versions which are no longer available

@bric3

bric3 commented May 15, 2025

Copy link
Copy Markdown

@roele Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants